Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins configuration change for node-test-binary-windows-js-suites #2801

Closed
Trott opened this issue Nov 1, 2021 · 2 comments
Closed

Jenkins configuration change for node-test-binary-windows-js-suites #2801

Trott opened this issue Nov 1, 2021 · 2 comments
Labels
ci-change PSA of configuration changes

Comments

@Trott
Copy link
Member

Trott commented Nov 1, 2021

I increased the timeout for node-test-binary-windows-js-suites from 600 seconds to 900 seconds. Should this be documented somewhere? I'm not sure if/how we track config changes. (And I'm fairly certain this is not the first time I've asked. Sorry!)

@richardlau richardlau added the ci-change PSA of configuration changes label Nov 1, 2021
@Trott
Copy link
Member Author

Trott commented Nov 1, 2021

Ref: nodejs/node#40684

@richardlau
Copy link
Member

I increased the timeout for node-test-binary-windows-js-suites from 600 seconds to 900 seconds. Should this be documented somewhere? I'm not sure if/how we track config changes. (And I'm fairly certain this is not the first time I've asked. Sorry!)

I think issue raised to document the change is sufficient (so we can search for it if needed). We have a cron job to backup the Jenkins config (FWIW your change is captured in https://github.com/nodejs/jenkins-config-test/commit/d21a56afe468d322063a9a6fad3e15b780772afb).

@Trott Trott closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-change PSA of configuration changes
Projects
None yet
Development

No branches or pull requests

2 participants