Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give access to @UlisesGascon to Mac OS test machines #3068

Closed
UlisesGascon opened this issue Nov 4, 2022 · 8 comments
Closed

Give access to @UlisesGascon to Mac OS test machines #3068

UlisesGascon opened this issue Nov 4, 2022 · 8 comments

Comments

@UlisesGascon
Copy link
Member

As requested by @richardlau in Slack, I open this issue so we don't lose track :)

@mhdawson
Copy link
Member

mhdawson commented Nov 4, 2022

@UlisesGascon would you be interested in helping out with the MacOS infra? We are short of people supporting that right now.

@UlisesGascon
Copy link
Member Author

Sure @mhdawson! How do I get started?

@mhdawson mhdawson changed the title I want to help in Node.js build team Give access to @UlisesGascon to Mac OS test machines Nov 7, 2022
@mhdawson
Copy link
Member

mhdawson commented Nov 7, 2022

I think the first step is to agree to give @UlisesGascon ongoing access to the MacOS machines in our test infra.

As per:https://github.com/nodejs/build/blob/main/GOVERNANCE.md#special-access-requests

In these cases the following will be used to decide if ongoing access can be provided:

  • Does the scope and size of the need justify providing access.
    • Yes we need help maintaining the MacOS machines. It seems to be slowly degrading despite
      the work (many thanks) being done by existing build WG members, for example during the
      last set of security releases there was only 1 machine available meaning each built
      took 2 hours sequentially.
  • Is the individual a collaborator. If so then access should be allowed provided the first point is satisfied.
    • No
  • Length and consistency of involvement with Node.js working groups and/or community.
  • Consequences to the individual in case of misbehaviour. For example, would they potentially lose their job if they were reported as mis-behaving to their employer ? Would being banned from involvement in the Node.js community negatively affect them personally in some other way ?
    • They work at one-beyond.com and list there OpenSource contributions prominently on resumes/linked in etc. Misbehaviour would likely have a negative impact on their chosen career path.
  • Are there collaborators who work with the individual and can vouch for them.
    • I don't work with @UlisesGascon directly, but from his involvement/participation in the
      security-wg I'm confortable with giving him access to at least one of the
      MacOS test infra.

@mhdawson
Copy link
Member

mhdawson commented Nov 7, 2022

@nodejs/build

@Trott
Copy link
Member

Trott commented Nov 8, 2022

SGTM

@richardlau
Copy link
Member

+1

@richardlau
Copy link
Member

I've invited @UlisesGascon to nodejs-private and added them to the build team there so they can access the secrets repo. Their gpg key has been added to the build/test and build/infra-mac areas of the secrets repo.

@UlisesGascon
Copy link
Member Author

Thanks @richardlau for grant me access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants