Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has weird issues when trying to get changes based on refs. #8

Open
Fishrock123 opened this issue Apr 9, 2015 · 1 comment
Open

Comments

@Fishrock123
Copy link
Member

Sometimes it will drop commits, add to many commits, not get anything at all, etc, when using --start-ref= and/or --end-ref= on io.js.

For example, to get the commits in nodejs/node#1383 (comment) I ran changelog-maker --start-ref=b8310cb --end-ref=08e89b1 iojs io.js, but it gets commits well before b8310cb also.

(This is the same issue I had trying to use this to make the 1.6.4 release before it was properly re-tagged.)

@rvagg
Copy link
Member

rvagg commented May 11, 2015

I think this is about the whole 1.x / master thing, what it's doing is getting the dates of the given refs and then looking at the commit log between those two dates. I haven't come up with a cleaner way than this yet but I'm sure there is one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants