Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react to the CITGM #1038

Open
RafaelGSS opened this issue Dec 14, 2023 · 2 comments · May be fixed by #1059
Open

Add react to the CITGM #1038

RafaelGSS opened this issue Dec 14, 2023 · 2 comments · May be fixed by #1059

Comments

@RafaelGSS
Copy link
Member

This seems like an important one to get working. I guess if we’ve been skipping it since Node 12 then it’s de facto already removed, but it feels like one we should add back if we can.

Originally posted by @GeoffreyBooth in #1036 (comment)
@targos
Copy link
Member

targos commented May 9, 2024

Smoke test: https://github.com/nodejs/citgm/actions/runs/9016187373

targos added a commit to targos/citgm that referenced this issue May 9, 2024
@targos
lookup: add React
6ed37c2 
Closes: nodejs#1038
@targos targos linked a pull request May 9, 2024 that will close this issue
Draft
@targos
Copy link
Member

targos commented May 9, 2024

I opened a PR, but it's not looking good!
#1059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lookup: add React targos/citgm
2 participants
@targos @RafaelGSS