Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

through2@4.0.2 chromium binary is not available for arm64 #1040

Open
RafaelGSS opened this issue Dec 19, 2023 · 1 comment
Open

through2@4.0.2 chromium binary is not available for arm64 #1040

RafaelGSS opened this issue Dec 19, 2023 · 1 comment

Comments

@RafaelGSS
Copy link
Member

We've experienced some issues on v21.x when running the suite on osx11

Ref:

Can we skip an environment in a specific version? v21.x >=

@ljharb ljharb changed the title through@4.0.2 chromium binary is not available for arm64 through2@4.0.2 chromium binary is not available for arm64 Dec 19, 2023
@targos
Copy link
Member

targos commented Dec 20, 2023

Can this be fixed in through2? I doubt it actually needs puppeteer for its test.

To answer your question, I don't know if that's the intended way, but it seems you can combine conditions by using an object:

"skip": {
  "osx11": ">=21"
}

isObjectMatch(obj) {
return _.some(obj, (value, key) => {
if (!this.isStringMatch(key)) return false;
if (typeof value === 'boolean') return value;
if (typeof value === 'string') return this.isStringMatch(value);
if (Array.isArray(value)) return this.isArrayMatch(value);
return false;
});
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants