Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v14.x failures #797

Closed
4 tasks done
BethGriggs opened this issue Mar 18, 2020 · 6 comments
Closed
4 tasks done

Node.js v14.x failures #797

BethGriggs opened this issue Mar 18, 2020 · 6 comments

Comments

@BethGriggs
Copy link
Member

BethGriggs commented Mar 18, 2020

Raising this issue to cover failures and flakes for Node.js 14.

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2314/testReport/

All platforms

Multiple

  • ember-cli-v3.17.0
@targos
Copy link
Member

targos commented Mar 18, 2020

resolve is expected to fail at the moment.
@ljharb I don't remember what we needed to do to make sure it's fixed by the release of v14 ?

@ljharb
Copy link
Member

ljharb commented Mar 18, 2020

I have to publish a new version, and I have to have an unbreakable commitment from the build team that v14.0.0 will be the first version in which fs/promises is a builtin module so that I can safely publish a new patch of resolve prior to v14 being released :-)

@BethGriggs
Copy link
Member Author

@ljharb, v14.x is due to be released Tuesday 21st April containing nodejs/node#31553 (I don't want to say unbreakable commitment, but there are no plans to back this PR out of v14.x.)

@dominykas
Copy link
Member

We do have nodejs/package-maintenance#261 open in package-maintenance - but a little unsure on what are the steps that need to be taken here? How can I help?

@ljharb
Copy link
Member

ljharb commented Apr 15, 2020

@BethGriggs v1.16.0 of resolve now considers fs/promises a core module in node 14+.

@BethGriggs
Copy link
Member Author

This issue is fairly stale and I believe each of the failures have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants