Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Foundation Diagnostics WorkGroup Meeting 2018-04-04 #178

Closed
mhdawson opened this issue Apr 2, 2018 · 12 comments
Closed

Node.js Foundation Diagnostics WorkGroup Meeting 2018-04-04 #178

mhdawson opened this issue Apr 2, 2018 · 12 comments
Assignees

Comments

@mhdawson
Copy link
Member

mhdawson commented Apr 2, 2018

Time

UTC Wed 04-Apr-2018 19:00 (07:00 PM):

Timezone Date/Time
US / Pacific Wed 04-Apr-2018 12:00 (12:00 PM)
US / Mountain Wed 04-Apr-2018 13:00 (01:00 PM)
US / Central Wed 04-Apr-2018 14:00 (02:00 PM)
US / Eastern Wed 04-Apr-2018 15:00 (03:00 PM)
London Wed 04-Apr-2018 20:00 (08:00 PM)
Amsterdam Wed 04-Apr-2018 21:00 (09:00 PM)
Moscow Wed 04-Apr-2018 22:00 (10:00 PM)
Chennai Thu 05-Apr-2018 00:30 (12:30 AM)
Hangzhou Thu 05-Apr-2018 03:00 (03:00 AM)
Tokyo Thu 05-Apr-2018 04:00 (04:00 AM)
Sydney Thu 05-Apr-2018 05:00 (05:00 AM)

Or in your local time:

Links

Agenda

Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/diagnostics

Invited

  • Diagnostics team: @nodejs/diagnostics

Observers

Notes

The agenda comes from issues labelled with diag-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this Apr 2, 2018
@mhdawson
Copy link
Member Author

mhdawson commented Apr 2, 2018

I have a conflict this week (community planning meeting) so I won't be able to make it. I missed that recurring conflict so this slot is going to be a challenge for me.

@mhdawson
Copy link
Member Author

mhdawson commented Apr 2, 2018

Just noticed that the tag was incorrect in the templates. That explains where there are no agenda items tagged. Its fixed now but @mike-kaufman for this time you'll need to add them manually.

@mhdawson
Copy link
Member Author

mhdawson commented Apr 2, 2018

Create this issue from my action in last meeting: #180

Likely needs quite a bit of refinement but at least a start for discussion.

@mike-kaufman
Copy link
Contributor

agenda updated.

@Flarna
Copy link
Member

Flarna commented Apr 4, 2018

I will try to participate but no need for you to wait.

@hashseed
Copy link
Member

hashseed commented Apr 4, 2018

Can't participate today unfortunately.

@mmarchini
Copy link
Contributor

Won't be able to join today as well, so here's a quick update on the CPU Profiling front (#148):

  • There's a CL open on V8 (v8:959081) to allow Linux perf and other external profilers to work nicely with Interpreted Frames.
  • We had a few setbacks on it because the field SharedFunctionInfo::code field was removed, and the first implementation was relying on it.
    • We're still trying to figure out the best way to implement it without the code field.
  • Original ETA was to land this before April 10, so it would be available on V8 6.7 and on the first release of Node.js 10, but it might take more time to finish and land this.
  • If we miss the V8 6.7 branch cut and we want to ship Node.js 10 with this feature, we could float the commit to Node.js.
    • Or maybe backport it to V8 6.7 (not sure if it's possible though, @hashseed?)
    • In the worst case scenario it will only be available on V8 6.8 (cut date: May 24th)

@hashseed
Copy link
Member

hashseed commented Apr 4, 2018

I'm fairly pessimistic about back porting in upstream, and would also advise against floating. The change is somewhat intrusive.

I'm pretty sure we can get V8 6.8 into Node.js 10 though.

@mhdawson
Copy link
Member Author

mhdawson commented Apr 4, 2018

A request that we try to move future meeting so I can make it in the future. I think an hour earlier or later would work for me.

@Qard
Copy link
Member

Qard commented Apr 4, 2018

I think an hour earlier probably works for the most people? Perhaps we should set up another doodle?

@mhdawson
Copy link
Member Author

mhdawson commented Apr 4, 2018

The other option may be to slip by a week. It conflicts with a meeting that happens every other week an d maybe its that one of the 2 slipped by a week in the past and they now align. If we push the diagnostics meeting by a week and keep the same time that would avoid the conflict for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants