Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Diagnostics WorkGroup Meeting 2020-11-11 #441

Closed
mhdawson opened this issue Nov 9, 2020 · 16 comments
Closed

Node.js Diagnostics WorkGroup Meeting 2020-11-11 #441

mhdawson opened this issue Nov 9, 2020 · 16 comments
Assignees

Comments

@mhdawson
Copy link
Member

mhdawson commented Nov 9, 2020

Time

UTC Wed 11-Nov-2020 17:30 (05:30 PM):

Timezone Date/Time
US / Pacific Wed 11-Nov-2020 09:30 (09:30 AM)
US / Mountain Wed 11-Nov-2020 10:30 (10:30 AM)
US / Central Wed 11-Nov-2020 11:30 (11:30 AM)
US / Eastern Wed 11-Nov-2020 12:30 (12:30 PM)
EU / Western Wed 11-Nov-2020 17:30 (05:30 PM)
EU / Central Wed 11-Nov-2020 18:30 (06:30 PM)
EU / Eastern Wed 11-Nov-2020 19:30 (07:30 PM)
Moscow Wed 11-Nov-2020 20:30 (08:30 PM)
Chennai Wed 11-Nov-2020 23:00 (11:00 PM)
Hangzhou Thu 12-Nov-2020 01:30 (01:30 AM)
Tokyo Thu 12-Nov-2020 02:30 (02:30 AM)
Sydney Thu 12-Nov-2020 04:30 (04:30 AM)

Or in your local time:

Links

Agenda

Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

Invited

  • Diagnostics team: @nodejs/diagnostics

Observers/Guests

Notes

The agenda comes from issues labelled with diag-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this Nov 9, 2020
@RafaelGSS
Copy link
Member

Are missing the issues?

@gireeshpunathil
Copy link
Member

looks like the (meeting-generating) script error. /cc @mhdawson

let us use agenda generated for the previous meeting? may be some additions & deletions that we can figure out in the meeting

@RafaelGSS
Copy link
Member

Indeed.

@gireeshpunathil
Copy link
Member

It was only 3 of us in the meeting, so we declared the meeting as cancelled. Will re-convene in 2 weeks time.

@Qard
Copy link
Member

Qard commented Nov 11, 2020

The schedule says it doesn’t start for another twenty minutes. 🤔

@mmarchini
Copy link
Contributor

mmarchini commented Nov 11, 2020

FYI the US went off daylight saving time last week, and the meeting is (apparently) scheduled based on US time. It shows 9:30am PST in the schedule above and calendar, it's 9:11am PST now here.

@mmarchini
Copy link
Contributor

Speaking of which, the meeting time should not change when a country goes in our out daylight saving time.

@gireeshpunathil
Copy link
Member

o! my bad. Did not notice the change in the calendar.

@RafaelGSS
Copy link
Member

RafaelGSS commented Nov 11, 2020

Probably I used to join the normal meeting time from my timezone. I see now that the meeting should start at 2h30PM (GMT-3). So, I'm able to join again 👍

@gireeshpunathil
Copy link
Member

@mmarchini - are you available to run the meeting? If yes, I would like to opt out (due to the misunderstanding, I had kept some other plans)

@mmarchini
Copy link
Contributor

@gireeshpunathil yes, I can run the meeting today :)

Does the current time (as it shows on the calendar) works for everyone moving forward? Otherwise I can start a Doodle to figure out a better time.

@legendecas
Copy link
Member

I'm afraid I'll not be available for the changed meeting time due to daylight saving. It's too late in UTC+8 area.

@mmarchini
Copy link
Contributor

Created #442 to discuss meeting time changes if those are necessary.

@Qard
Copy link
Member

Qard commented Nov 11, 2020

There was only three this time too so we decided to cut it short. I would like to get some more attention on these PRs though:

  • lib: add span API to diagnostics_channel #35534
  • lib: make diagnostics_channel async iterable #35532

There was also a suggestion about a blog post for diagnostics_channel that we can point new module authors to as encouragement to try the API in their modules. :)

@mmarchini
Copy link
Contributor

mmarchini commented Nov 11, 2020

We canceled the meeting since there were only the three of us and there wasn't much to discuss on actionable topics. Only things I'd like to highlight:

  1. We briefly discussed creating an issue to track diagnostic_channels documentation as well as adoption in the ecosystem (could be two issues)
  2. We briefly discussed CPU PRofiling roadmap. Current issue should be closed and remaining topics (being able to capture profile without stopping) should go on a separate issue
  3. Please review lib: add span API to diagnostics_channel node#35534 and lib: make diagnostics_channel async iterable  node#35532

(edit @Qard beat me to it 😅)

@mhdawson
Copy link
Member Author

Thanks, had a meeting that ran late so only tried to join 30 mins late. Thanks for the updates on the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants