Diag WG Meeting - 2017-01-19

[joshgav]

Date/Time

Thursday Jan 19 2000 UTC (12pm US Pacific)

It's helpful if you give this post a 👍 or 👎 so we know you'll be attending. Thanks!

Join/Watch

If you are only observing please use the YouTube channel; Hangouts limits the number of connections.

• Watch on YouTube: http://youtu.be/sMkzvd9Lf74
• Participate on Hangouts: https://hangouts.google.com/hangouts/_/ytl/9unU1P2s7ypaAu9YbP-mxzklTAY1HCgDyZAiYP19S7s=?eid=100598160817214911030

Minutes

• Minutes: https://docs.google.com/document/d/146Y4TMLa0_uovREHalBsobspWSSog4N2k3TIJe_Co84
• Previous minutes: https://github.com/nodejs/diagnostics/blob/master/wg-meetings/2016-12-02.md

Agenda

Inspector

• RFC: Support for subprocess inspection diagnostics#77
• Support for HTTP/WS inspection diagnostics#75
• src, lib: deprecate old debug-agent and CLI debugger node#10276
• inspector, doc: update hint text, add guide node#8978
• Bringing node-inspect into the fold diagnostics#67
• Bring 'node-inspect' (CLI Debugger) under the Foundation tsc#190
• deps: Add node-inspect node#10187
• Move bnoordhuis/node-heapdump to nodejs/node-heapdump post-mortem#40

Trace

• Trace Events trace system in Node.js diagnostics#53
• trace_event.h tracking issue diagnostics#30
• proposal: JS tracing APIs node-eps#48

Async Context

• async_hooks initial implementation node#8531
• What will Domain be replaced with? node#10843

Post-Mortem

• node-report
• llnode

---

/cc @nodejs/diagnostics @nodejs/post-mortem

[joshgav]

Will fill in the agenda with relevant issues from this and other repos. Please suggest more in this thread.

Everyone please fill in the Doodle by end of week (1/13) so we can settle on a time.

@mhdawson @yunong @rnchamberlain @richardlau - would it be worth discussing topics from the nodejs/post-mortem repo in the Diagnostics meetings too? For me at least I try to stay deeply on top of both :)

[mhdawson]

I won't be able to make it the week of Jan 16-20 as I'm off on holiday.

[rnchamberlain]

@joshgav yes it would be good to discuss some of the post mortem work if there is time in your meeting, doodle poll updated, thanks

[joshgav]

@mhdawson are you asking us to defer for a week? Otherwise, I think Thursday at 2000 UTC (12pm Pacific) works for everyone, so I updated the OP accordingly.

I also added a number of issues to the agenda from here and nodejs/node, we can trim if some can simply continue progressing through discussion in GitHub. If you'd like to add others please comment here or edit the OP if you prefer.

Thanks!

[watson]

I'm going to NodeConf Budapest on the 19th unfortunately, so I don't think I can make it 😞
I updated the description to say you should 👎 if you can't make it so @joshgav knows if people have seen it

[joshgav]

Reminder that we're scheduled to meet tomorrow (Thursday 1/19) at 12pm US Pacific, 2000 UTC. See you then!

[AndreasMadsen]

AsyncHooks is such a minor part of todays agenda that I'm not going to join.

---

A short update on async_hooks (it is actually all I know)

A while ago Trevor said the following where missing:

• Remove all weak objects (will be handled in another PR to solve another issue)
• Add support to node::MakeCallback
• Implement public native API.
• Detect a change in the hooks queue when in the middle of running hooks, so the original set of hooks can finish executing.

My best guess is that only "Add support to node::MakeCallback" and "Implement public native API" is missing now, but that he want to test the current implement first.

[richardlau]

Apologies, this is my first time using Hangouts. I'm getting a 403 error trying to access the participate link in the description.

[rnchamberlain]

me too

[joshgav]

Thanks, working on it now. Perhaps you need to be signed in to a Google account? We're testing here in the MS office too.

[joshgav]

Confirmed that you need to be signed into a Google account. Can you try that?

[rnchamberlain]

I'm signed in - mugshot appears in top right of google page

[rnchamberlain]

watching on utube ok

[richardlau]

Same, am signed in. I'll follow on youtube.

[richardlau]

Got in, had to removed the end of the url (everything after the ?).

[joshgav]

Sorry @rnchamberlain @richardlau, glad you were able to get in eventually.

@richardlau

had to remove the end of the url (everything after the ?)

<sigh> a couple meetings ago I lopped off the query string (after the ?) and it broke people. Thanks for the tip though, now we know something to try in the future :)

Will get the notes into a PR soon. Thanks everyone!

[joshgav]

Thanks @AndreasMadsen for the update on async_hooks, including that in the notes for reference.

[joshgav]

notes landed: https://github.com/nodejs/diagnostics/blob/master/wg-meetings/2017-01-19.md