Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename primary branch to main #302

Closed
mhdawson opened this issue May 17, 2021 · 4 comments
Closed

Rename primary branch to main #302

mhdawson opened this issue May 17, 2021 · 4 comments

Comments

@mhdawson
Copy link
Member

We are going through all of the node.js repositories to rename the primary branch to main. Please see nodejs/node#33864 for more context.

There may need to be some changes outside the repository if anything references main specifically as a target for the github-bot. f that is the case we'd need to sync the rename and those changes outside the repository.

Could those more familiar with the github bot comment on that, or if we can just rename the primary branch to main without and other concerns.

@phillipj
Copy link
Member

Sure thing, I'll double check the github-bot's code.

A recent PR in the node-pr-labeler action also comes to mind: nodejs/node-pr-labeler#9. I'll dive into better alternatives.

@mhdawson
Copy link
Member Author

@phillipj are you comfortable I can go ahead and do the rename now?

@phillipj
Copy link
Member

@mhdawson yupp. Let's do it and just ping me directly if any thing seems weird after the fact.

The only thing I've got on my todo, is updating the auto deploy mechanisms in nodejs/build/github-bot-deploy-webhook.json.j2 when commits lands into github-bot/main as opposed to master, but that's not a blocker in my eyes.

@mhdawson
Copy link
Member Author

@phillipj thanks. Renamed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants