Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save spans on pause #14

Open
indutny opened this issue Mar 1, 2018 · 1 comment
Open

Save spans on pause #14

indutny opened this issue Mar 1, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@indutny
Copy link
Member

indutny commented Mar 1, 2018

There's no need to save/restore spans on every .start()/.end(). The set of active spans is known for each node ahead of time, so we can just store them at .pause().
@indutny indutny added the enhancement New feature or request label Mar 1, 2018
@indutny
Copy link
Member Author

indutny commented Mar 1, 2018

This will require passing all span starts around. Probably not feasible for multiple-spans, but is worth exploring for a single span case (http-parser).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@indutny