Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Loaders Team Meeting 2024-04-09 #191

Open
mhdawson opened this issue Apr 5, 2024 · 15 comments
Open

Node.js Loaders Team Meeting 2024-04-09 #191

mhdawson opened this issue Apr 5, 2024 · 15 comments
Assignees

Comments

@mhdawson
Copy link
Member

mhdawson commented Apr 5, 2024

Time

UTC Tue 09-Apr-2024 18:30 (06:30 PM):

Timezone Date/Time
US / Pacific Tue 09-Apr-2024 11:30 (11:30 AM)
US / Mountain Tue 09-Apr-2024 12:30 (12:30 PM)
US / Central Tue 09-Apr-2024 13:30 (01:30 PM)
US / Eastern Tue 09-Apr-2024 14:30 (02:30 PM)
EU / Western Tue 09-Apr-2024 19:30 (07:30 PM)
EU / Central Tue 09-Apr-2024 20:30 (08:30 PM)
EU / Eastern Tue 09-Apr-2024 21:30 (09:30 PM)
Moscow Tue 09-Apr-2024 21:30 (09:30 PM)
Hangzhou Wed 10-Apr-2024 02:30 (02:30 AM)
Tokyo Wed 10-Apr-2024 03:30 (03:30 AM)
Sydney Wed 10-Apr-2024 04:30 (04:30 AM)

Links

Agenda

Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/node

  • Proposal for a simple, universal module loader hooks API to replace require() monkey-patching #52219
  • ESM Hook deadlocks since 21.2.0 a3e09b3 #50948
  • esm: spawn only one hooks thread #50752

Invited

  • Loaders team: @nodejs/loaders

Observers/Guests

Notes

The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this Apr 5, 2024
@dygabo
Copy link

dygabo commented Apr 8, 2024

Based on the input I heard during the collab summit from last week that the @nodejs/loaders team is looking for more collaborators and support in implementing some of the open tasks, considering also that I am interested in any contributions that might bring node.js esm implementation/modules to a state that is APM friendlier I would like to participate to the ongoing discussion around #52219 and see if there is something I can do to support the efforts.

@JakobJingleheimer
Copy link
Contributor

Hiya @dygabo we would love some help! The issue you cited maaay be a very large first-bite though.

Do you have any particular areas of expertise? If so, I can maybe point you to an open issue; you're welcome to try at the one you cited, but I worry you may spin your wheels.

I'm returning from a hiatus, so I may be able to support; I was hoping to jump back onto nodejs/node#50752 (and maybe some cleanup).

@dygabo
Copy link

dygabo commented Apr 9, 2024

Hi @JakobJingleheimer and thanks for the reply, I work in observability domain, being part of a team working on a node.js apm solution. I have some previous contributions to node.js loaders area about two years ago, concerning returning the module type from the resolve hook instead of during load. I for sure still would need to read into the open issues and also into the challenges that you have currently on your agenda and I think I could participate in the discussions, maybe also some code changes. I'm sure that having a working solution on #52219 is not an easy task and I did not want to imply that I would solve that on my own, without collaboration with the rest of the team. More like the other way around, it would make sense IMO that the team continues to work on it and maybe I could help with some input, ideas, reviews, tests, etc. I could jump in one of the group meetings (e.g. this one today) and we could discuss it more and maybe take it from there. What do you think?

@JakobJingleheimer
Copy link
Contributor

Oh sure! Do join this evening's meeting if it happens 🙂

@GeoffreyBooth
Copy link
Member

I have a conflict for the first half-hour, can we start 30 minutes late?

@JakobJingleheimer
Copy link
Contributor

I can do

@GeoffreyBooth
Copy link
Member

GeoffreyBooth commented Apr 9, 2024

@joyeecheung We’d love to see you too if you can attend, at UTC Tue 09-Apr-2024 18:30.

@jsumners-nr
Copy link

I'd like to attend to at least listen in, but my team always has its "planning" and "grooming" meetings at this time.

@JakobJingleheimer
Copy link
Contributor

Should we reschedule this occurrence for a different day? (Any later is too late for me)

@jsumners-nr
Copy link

I doubt it's worth rescheduling on my account, but my only viable day would be Friday.

@jsumners-nr
Copy link

Looks like I can pop in for the first 30 minutes today.

@GeoffreyBooth
Copy link
Member

Looks like I can pop in for the first 30 minutes today.

FYI we’ll start at UTC Tue 09-Apr-2024 18:30 (06:30 PM) today. I just updated the top post.

@jsumners-nr
Copy link

Then maybe next time.

@joyeecheung
Copy link
Member

I think I can attend the first 30 minutes but will need to go after that or I will have no bed to sleep on...

@joyeecheung
Copy link
Member

(Or maybe I can rejoin after leaving for ~15 minutes, not too sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants