Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Loaders Team Meeting 2022-07-05 #91

Closed
mhdawson opened this issue Jul 1, 2022 · 9 comments
Closed

Node.js Loaders Team Meeting 2022-07-05 #91

mhdawson opened this issue Jul 1, 2022 · 9 comments
Assignees

Comments

@mhdawson
Copy link
Member

mhdawson commented Jul 1, 2022

Time

UTC Tue 05-Jul-2022 18:00 (06:00 PM):

Timezone Date/Time
US / Pacific Tue 05-Jul-2022 11:00 (11:00 AM)
US / Mountain Tue 05-Jul-2022 12:00 (12:00 PM)
US / Central Tue 05-Jul-2022 13:00 (01:00 PM)
US / Eastern Tue 05-Jul-2022 14:00 (02:00 PM)
EU / Western Tue 05-Jul-2022 19:00 (07:00 PM)
EU / Central Tue 05-Jul-2022 20:00 (08:00 PM)
EU / Eastern Tue 05-Jul-2022 21:00 (09:00 PM)
Moscow Tue 05-Jul-2022 21:00 (09:00 PM)
Chennai Tue 05-Jul-2022 23:30 (11:30 PM)
Hangzhou Wed 06-Jul-2022 02:00 (02:00 AM)
Tokyo Wed 06-Jul-2022 03:00 (03:00 AM)
Sydney Wed 06-Jul-2022 04:00 (04:00 AM)

Or in your local time:

Links

Agenda

Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/loaders

Invited

  • Loaders team: @nodejs/loaders

Observers/Guests

Notes

The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

@mhdawson mhdawson self-assigned this Jul 1, 2022
@GeoffreyBooth
Copy link
Member

We discussed preImport last time; I forgot to remove the agenda label until just now. I don’t think there’s anything else to discuss at the moment, or is there? Anything about moving loaders off-thread? @JakobJingleheimer @bmeck

@JakobJingleheimer
Copy link
Contributor

I think I'll first tackle a couple tidy tasks (ex add some more test cases), which I think will be useful to have before the off-thread work. I expect the tidy stuff to be fairly quick and unobjectionable.

But if anyone has a strong preference, do LMK.

PS Does anyone know when the next release is?

@cspotcode
Copy link
Contributor

cspotcode commented Jul 1, 2022 via email

@GeoffreyBooth
Copy link
Member

There’s that bug(?) on node nightly where calling runMain causes loaders in the chain to be re-added and thus duplicated, might be worth looking at before the next release as well.

Link?

Is there a ticket for moving loaders off-thread? If not, I assume we should make one? Since design considerations and potential gotchas have already been brought up, but not a great place to put them.

There isn’t, that I can find. Would you like to make one? The one that comes closest seems to be #13.

@GeoffreyBooth
Copy link
Member

PS Does anyone know when the next release is?

nodejs/Release#737

@JakobJingleheimer
Copy link
Contributor

PS Does anyone know when the next release is?

nodejs/Release#737

What? No, I mean 18.5.0 or whatever

@cspotcode
Copy link
Contributor

Here is a Slack link regarding the runMain loader duplication behavior:
https://openjs-foundation.slack.com/archives/C01810KG1EF/p1653603118031189

Probably best for the folks heading up the off-thread task to create that ticket. Seems like they have ideas about how it's supposed to go? And then the rest of us can add our comments.

@JakobJingleheimer
Copy link
Contributor

Are we cancelling or meeting today?

@GeoffreyBooth
Copy link
Member

No agenda, so I guess we cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants