add missing overload for Nan::NewInstance that takes argc/argv

nodejs · Aug 6, 2015 · 29450ed · 29450ed
1 parent e281d4e
commit 29450ed
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/doc/maybe_types.md b/doc/maybe_types.md
@@ -159,6 +159,7 @@ Signature:
 
 ```c++
 Nan::MaybeLocal<v8::Object> Nan::NewInstance(v8::Local<v8::Function> h);
+Nan::MaybeLocal<v8::Object> Nan::NewInstance(v8::Local<v8::Function> h, int argc, v8::Local<v8::Value> argv[]);
 Nan::MaybeLocal<v8::Object> Nan::NewInstance(v8::Local<v8::ObjectTemplate> h);
 ```
 

diff --git a/nan_maybe_43_inl.h b/nan_maybe_43_inl.h
@@ -47,6 +47,15 @@ MaybeLocal<v8::Object> NewInstance(v8::Local<v8::Function> h) {
   return MaybeLocal<v8::Object>(h->NewInstance(GetCurrentContext()));
 }
 
+NAN_INLINE
+MaybeLocal<v8::Object> NewInstance(
+      v8::Local<v8::Function> h
+    , int argc
+    , v8::Local<v8::Value> argv[]) {
+  return MaybeLocal<v8::Object>(h->NewInstance(GetCurrentContext(),
+                                argc, argv));
+}
+
 NAN_INLINE
 MaybeLocal<v8::Object> NewInstance(v8::Local<v8::ObjectTemplate> h) {
   return MaybeLocal<v8::Object>(h->NewInstance(GetCurrentContext()));

diff --git a/nan_maybe_pre_43_inl.h b/nan_maybe_pre_43_inl.h
@@ -114,6 +114,14 @@ MaybeLocal<v8::Object> NewInstance(v8::Handle<v8::Function> h) {
   return MaybeLocal<v8::Object>(h->NewInstance());
 }
 
+NAN_INLINE
+MaybeLocal<v8::Object> NewInstance(
+      v8::Local<v8::Function> h
+    , int argc
+    , v8::Local<v8::Value> argv[]) {
+  return MaybeLocal<v8::Object>(h->NewInstance(argc, argv));
+}
+
 NAN_INLINE
 MaybeLocal<v8::Object> NewInstance(v8::Handle<v8::ObjectTemplate> h) {
   return MaybeLocal<v8::Object>(h->NewInstance());