Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scope.Escape() to Call() #817

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Add scope.Escape() to Call() #817

merged 1 commit into from
Oct 22, 2018

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Oct 19, 2018

Added a scope.Escape() in Call() as suggested by @addaleax in #813.

fixes: #813

@Flarna Flarna mentioned this pull request Oct 19, 2018
Closed
@kkoopa kkoopa merged commit 2e5ed4f into nodejs:master Oct 22, 2018
@kkoopa
Copy link
Collaborator

kkoopa commented Oct 22, 2018

Thank you for making the PR.

@Flarna Flarna deleted the fix_call_scope_escape branch October 22, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nan::Callback::Call improperly garbage collects the return value under Node 10.12, causing segfaults
3 participants
@Flarna @kkoopa @addaleax