Support for Node 12 #849

xzyfer · 2019-04-24T01:42:43Z

Simply opening this as a tracking issue we can subscribe to and link to in upstream issues.

Flarna · 2019-04-25T10:10:00Z

I tried with Node 12 and it seems Nan 2.13.2 works fine as is.

The missing part in this repo seems to be only adding #define NODE_12_0_MODULE_VERSION 72 and update readme,... but this shouldn't be blocking.

matoro · 2019-04-25T14:01:01Z

I am seeing these when trying to build sqlite3. Is this nan's fault?

In file included from ../../nan/nan_new.h:189,                                                                                                  
                 from ../../nan/nan.h:203,                                                                                                                                                                                                                                                                               
                 from ../src/database.h:10,                                                                                                                                                                                                                                                                              
                 from ../src/database.cc:4:                                                                                                                                                    
../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::Function>::return_t Nan::imp::Factory<v8::Function>::New(Nan::FunctionCallback, v8::Local<v8::Value>)’:
../../nan/nan_implementation_12_inl.h:105:32: error: no matching function for call to ‘v8::Function::New(v8::Isolate*&, void (&)(const v8::FunctionCallbackInfo<v8::Value>&), v8::Local<v8::Object>&)’
                           , obj));                                                                                                                                                                                                                                                                                      
                                ^

In file included from ../../nan/nan_new.h:189,                                                                                                                                                                                                                                                                           
                 from ../../nan/nan.h:203,                                                                                                                                                                           
                 from ../src/database.h:10,                                                                                                                                                    
                 from ../src/database.cc:4:                                                                                                                                                    
../../nan/nan_implementation_12_inl.h:337:58: error: expected primary-expression before ‘>’ token                                                                                              
   return v8::StringObject::New(value).As<v8::StringObject>();                   
                                                          ^                                                                                        
../../nan/nan_implementation_12_inl.h:337:60: error: expected primary-expression before ‘)’ token                                                                                                                                                                                                                        
   return v8::StringObject::New(value).As<v8::StringObject>();                                                                                                                                                                       
                                                            ^                                                                                                                                                       
In file included from ../src/database.h:10,                                                                                                                                                    
                 from ../src/database.cc:4:                                                                                                                                      
../../nan/nan.h: In constructor ‘Nan::Utf8String::Utf8String(v8::Local<v8::Value>)’:                                                                                                           
../../nan/nan.h:1034:53: error: no matching function for call to ‘v8::Value::ToString()’                                                                                                       
       v8::Local<v8::String> string = from->ToString();                                                                                                                                        
                                                     ^

matoro · 2019-04-25T14:09:00Z

One more:

In file included from ../src/database.h:10,                                                                                                                                                                                                                                                                              
                 from ../src/database.cc:4:                                                                                                                                                    
../../nan/nan.h:1044:74: error: no matching function for call to ‘v8::String::WriteUtf8(char*&, int, int, const int&)’                                                                                                                                                                                                  
         length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);                                                                                                                                                                                                                                             
                                                                          ^

Flarna · 2019-04-25T14:11:11Z

At least for the second one it seems like sqlite is directly using v8 API string->WriteUtf8() which has been removed.

matoro · 2019-04-25T14:20:57Z

@Flarna I don't think so. Am I reading this right?

#if NODE_MAJOR_VERSION >= 11
length_ = string->WriteUtf8(v8::Isolate::GetCurrent(), str_, static_cast<int>(len), 0, flags);

from

nan/nan.h

Line 1080 in 3bd8b1b

#if NODE_MAJOR_VERSION >= 11

This is being executed for versions 11 and up?

Flarna · 2019-04-25T14:26:26Z

@matoro Which version of sqlite3 are you using? Is the latest version of NAN in use?
For Node.JS >= 11 the WriteUtf8(v8::Isolate::GetCurrent(),..) should be used but in our error message above I can see that the other one without v8::Isolate as first arg is used. Could be related to use of an outdated NAN version.

Flarna · 2019-04-25T14:38:07Z

I just cloned https://github.com/mapbox/node-sqlite3 and built locally (windows) with success.

There are quite some deprecation warnings because sqlite uses Nan::ForceSet() and Nan::MakeCallback() without AsyncResource but no build errors like above.

matoro · 2019-04-25T14:38:08Z

I have patched the package I am building to bump to the latest version of sqlite3 (4.0.6) which depends on:

"dependencies": {
    "nan": "^2.12.1",
    "node-pre-gyp": "^0.11.0",
    "request": "^2.87.0"
},

Edit: I also had to bump natives to 1.1.6 which is an indirect dependency. Let me see if bumping nan to the latest fixes it.

Edit 2: scratch that, that's from master. sqlite3 release 4.0.6 depends on nan ~2.10.0.

Flarna · 2019-04-25T14:48:24Z

ok, if I use 4.0.6 instead maser of sqlite3 I can see the same errors. Most likely TryGhost/node-sqlite3#1093 fixed the issues but no release was made yet.
Maybe you have to wait on TryGhost/node-sqlite3#1150

junderw · 2019-04-26T02:03:53Z

tiny-secp256k1 maintainer here, here are the errors I found in NaN when compiling on v12.

In file included from ../../nan/nan_new.h:189:0,
                 from ../../nan/nan.h:223,
                 from ../native/addon.cpp:4:
../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::StringObject>::return_t Nan::imp::Factory<v8::StringObject>::New(v8::Local<v8::String>)’:
../../nan/nan_implementation_12_inl.h:356:37: error: no matching function for call to ‘v8::StringObject::New(v8::Local<v8::String>&)’
   return v8::StringObject::New(value).As<v8::StringObject>();

../../nan/nan_implementation_12_inl.h:356:58: error: expected primary-expression before ‘>’ token
   return v8::StringObject::New(value).As<v8::StringObject>();
                                                          ^
../../nan/nan_implementation_12_inl.h:356:60: error: expected primary-expression before ‘)’ token
   return v8::StringObject::New(value).As<v8::StringObject>();

../../nan/nan_object_wrap.h: In destructor ‘virtual Nan::ObjectWrap::~ObjectWrap()’:
../../nan/nan_object_wrap.h:24:25: error: ‘class Nan::Persistent<v8::Object>’ has no member named ‘IsNearDeath’
     assert(persistent().IsNearDeath());
                         ^
../../nan/nan_object_wrap.h: In static member function ‘static void Nan::ObjectWrap::WeakCallback(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)’:
../../nan/nan_object_wrap.h:127:26: error: ‘class Nan::Persistent<v8::Object>’ has no member named ‘IsNearDeath’
     assert(wrap->handle_.IsNearDeath());

xzyfer · 2019-04-26T02:53:24Z

IIRC the IsNearDeath error is fixed in the latest nan release.

…

On Fri., 26 Apr. 2019, 12:04 pm Jonathan Underwood, < ***@***.***> wrote: tiny-secp256k1 maintainer here, here are the errors I found in NaN when compiling on v12. In file included from ../../nan/nan_new.h:189:0, from ../../nan/nan.h:223, from ../native/addon.cpp:4: ../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::StringObject>::return_t Nan::imp::Factory<v8::StringObject>::New(v8::Local<v8::String>)’: ../../nan/nan_implementation_12_inl.h:356:37: error: no matching function for call to ‘v8::StringObject::New(v8::Local<v8::String>&)’ return v8::StringObject::New(value).As<v8::StringObject>(); ../../nan/nan_implementation_12_inl.h:356:58: error: expected primary-expression before ‘>’ token return v8::StringObject::New(value).As<v8::StringObject>(); ^ ../../nan/nan_implementation_12_inl.h:356:60: error: expected primary-expression before ‘)’ token return v8::StringObject::New(value).As<v8::StringObject>(); ../../nan/nan_object_wrap.h: In destructor ‘virtual Nan::ObjectWrap::~ObjectWrap()’: ../../nan/nan_object_wrap.h:24:25: error: ‘class Nan::Persistent<v8::Object>’ has no member named ‘IsNearDeath’ assert(persistent().IsNearDeath()); ^ ../../nan/nan_object_wrap.h: In static member function ‘static void Nan::ObjectWrap::WeakCallback(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)’: ../../nan/nan_object_wrap.h:127:26: error: ‘class Nan::Persistent<v8::Object>’ has no member named ‘IsNearDeath’ assert(wrap->handle_.IsNearDeath()); — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#849 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAENSWEHT2OO7AWVBIMRBALPSJPJHANCNFSM4HH7URQA> .

lrecknagel · 2019-04-26T07:45:42Z

I have a similar issue as @matoro with node-rdkafka:

Log:

...
../src/common.cc: In function ‘T NodeKafka::GetParameter(v8::Local<v8::Object>, std::__cxx11::string, T) [with T = std::__cxx11::basic_string<char>; std::__cxx11::string = std::__cxx11::basic_string<char>]’:
../src/common.cc:94:55: error: no matching function for call to ‘v8::Value::ToString()’
       v8::Local<v8::String> val = parameter->ToString();
...

Code:

...
v8::Local<v8::Value> parameter = Nan::Get(object, field).ToLocalChecked();
...
v8::Local<v8::String> val = parameter->ToString();

Any ideas on that case ?

Flarna · 2019-04-26T07:51:31Z

@lrecknagel Don't use v8 directly, use NAN or napi.
v8::Local<v8::String> val = parameter->ToString(); => Nan::To<v8::String>(parameter) should work.

darkgl0w · 2019-05-10T18:01:43Z

Hi,

EDIT: narrowed down this issue to outdated dependencies and possible flaky tests.
I made all nan relevant changes thanks to Flarna 👍 .

ccope · 2019-05-10T18:32:49Z

@darkgl0w Warnings are not errors, a memory dump might be required to diagnose the segfault

Flarna · 2019-05-10T19:15:27Z

Nan::MakeCallback() is deprecated since NodeJs 10. Your Node 10 build shows the same warnings.
see https://github.com/nodejs/nan/blob/master/doc/node_misc.md#api_nan_make_callback for more details.

@rokumatsumoto

* Temporarily fix Travis CI builds `nvm install node` will install the latest node version, which is 12 as of writing. Because of a problem in the resolved node-sass version this makes the builds fail. To get green builds until a proper fix for node 12 is introduced we'll install node 10, which is a LTS release, while 11 will be EOL in June 2019. @rokumatsumoto is maybe working on a fix, but I think green builds, especially for third party PRs are an important intermediate step. #2077 sass/node-sass#2633 nodejs/nan#849 https://github.com/nodejs/Release * Lock RuboCop to a version that supports Ruby 2.2 RuboCop 0.69.0 dropped support for Ruby 2.2, making RuboCop fail when it was installed since it pointed to the git repo instead of a specific version. https://github.com/rubocop-hq/rubocop/blob/v0.69.0/CHANGELOG.md#changes * Allow failures with ruby-head These might – currently – not be related to Ruby itself, but to the fact that bundler 2.1.0.pre.1 was installed, which is as of writing not supported by webpacker (`~> 1.12` is used). But this is to get the CI builds green again.

bnoordhuis · 2019-05-24T15:07:09Z

I'm going to close this out because I have no reason to believe at this point that the most recent release doesn't build with Node.js v12.x. The linked issues are either about older nan releases or caused by using Node or V8 APIs directly.

Case in point: @imrehg, that's not nan@2.13.2, going by the line numbers.

ralyodio · 2019-06-06T21:44:42Z

../../nan/nan_object_wrap.h:127:26: error: ‘class Nan::Persistentv8::Object’ has no member named ‘IsNearDeath’

kkoopa · 2019-06-06T22:13:55Z

fbaf422

See mapbox/node-cpp-skel#54 nodejs/nan#849

* Add support for node 12 See mapbox/node-cpp-skel#54 nodejs/nan#849 * updates * Only need this * Use compatible versions * use dockerfile * updates * caching * Run commands from docker * Fix cov report * Fixes * lowercase * re-add cov check * change back to yarn run

@rokumatsumoto

* Temporarily fix Travis CI builds `nvm install node` will install the latest node version, which is 12 as of writing. Because of a problem in the resolved node-sass version this makes the builds fail. To get green builds until a proper fix for node 12 is introduced we'll install node 10, which is a LTS release, while 11 will be EOL in June 2019. @rokumatsumoto is maybe working on a fix, but I think green builds, especially for third party PRs are an important intermediate step. rails/webpacker#2077 sass/node-sass#2633 nodejs/nan#849 https://github.com/nodejs/Release * Lock RuboCop to a version that supports Ruby 2.2 RuboCop 0.69.0 dropped support for Ruby 2.2, making RuboCop fail when it was installed since it pointed to the git repo instead of a specific version. https://github.com/rubocop-hq/rubocop/blob/v0.69.0/CHANGELOG.md#changes * Allow failures with ruby-head These might – currently – not be related to Ruby itself, but to the fact that bundler 2.1.0.pre.1 was installed, which is as of writing not supported by webpacker (`~> 1.12` is used). But this is to get the CI builds green again.

@rokumatsumoto

* Temporarily fix Travis CI builds `nvm install node` will install the latest node version, which is 12 as of writing. Because of a problem in the resolved node-sass version this makes the builds fail. To get green builds until a proper fix for node 12 is introduced we'll install node 10, which is a LTS release, while 11 will be EOL in June 2019. @rokumatsumoto is maybe working on a fix, but I think green builds, especially for third party PRs are an important intermediate step. rails/webpacker#2077 sass/node-sass#2633 nodejs/nan#849 https://github.com/nodejs/Release * Lock RuboCop to a version that supports Ruby 2.2 RuboCop 0.69.0 dropped support for Ruby 2.2, making RuboCop fail when it was installed since it pointed to the git repo instead of a specific version. https://github.com/rubocop-hq/rubocop/blob/v0.69.0/CHANGELOG.md#changes * Allow failures with ruby-head These might – currently – not be related to Ruby itself, but to the fact that bundler 2.1.0.pre.1 was installed, which is as of writing not supported by webpacker (`~> 1.12` is used). But this is to get the CI builds green again.

This was referenced Apr 24, 2019

Add support for Node 12 sass/node-sass#2633

Merged

support for node.js 12.x sass/node-sass#2632

Closed

fengmk2 mentioned this issue Apr 24, 2019

Update to build for Node.js v12 fsevents/fsevents#271

Closed

kriszyp mentioned this issue Apr 24, 2019

Support for Node 12 Venemo/node-lmdb#149

Closed

kesla mentioned this issue Apr 24, 2019

node 12 support kesla/node-snappy#168

Closed

huineng mentioned this issue Apr 24, 2019

node 12 support ibmdb/node-ibm_db#528

Closed

Flarna mentioned this issue Apr 25, 2019

Add node 12 support #850

Closed

matoro mentioned this issue Apr 25, 2019

nodejs 12 support TryGhost/node-sqlite3#1151

Closed

sam-github mentioned this issue Apr 25, 2019

v3.0.0 with Node v12/NPM 6.9.0 gives "TypeError: fsevents is not a constructor" facebook/create-react-app#6891

Closed

junderw mentioned this issue Apr 26, 2019

Doesn't work on NodeJS 12 bitcoinjs/tiny-secp256k1#38

Closed

h0x91b mentioned this issue Apr 26, 2019

Failure to compile on Node 12 h0x91b/redis-fast-driver#24

Closed

This was referenced Apr 27, 2019

Update for support node 12 cryptocoinjs/secp256k1-node#143

Merged

Update for support node 12 justmoon/node-bignum#120

Closed

zGrav mentioned this issue Apr 28, 2019

chore: package updates bitchcraft/reactjs-boilerplate#26

Merged

B4nan mentioned this issue Apr 28, 2019

Add support for node 12 mikro-orm/mikro-orm#50

Closed

josephg mentioned this issue Apr 30, 2019

Build fails with node 12 josephg/node-foundationdb#29

Closed

kryops mentioned this issue May 1, 2019

Add support for Node 12 MadLittleMods/node-usb-detection#81

Merged

Gasol mentioned this issue May 9, 2019

Add support for Node 12 apiaryio/protagonist#233

Merged

mildmojo mentioned this issue May 9, 2019

Node v12 support? Gottox/node-termios#5

Open

darkgl0w mentioned this issue May 10, 2019

[RESOLVED] Node 12 support brianc/node-libpq#68

Closed

eroncanc mentioned this issue May 18, 2019

npm install will fail with node 12 twbs/bootstrap#28786

Closed

nolanmar511 mentioned this issue May 20, 2019

Add support for node v12 googleapis/cloud-profiler-nodejs#490

Closed

aried3r mentioned this issue May 21, 2019

Fix Travis CI builds rails/webpacker#2098

Merged

bnoordhuis closed this as completed May 24, 2019

simon300000 mentioned this issue Jun 1, 2019

Fix build error at Node.js v12 luckykaiyi/nodejieba#132

Merged

htfy96 mentioned this issue Jun 13, 2019

Bump macaddress from 0.2.8 to 0.2.9 sjtug/sjtug-mirror-frontend#20

Closed

nickdesaulniers mentioned this issue Jun 30, 2019

Compile error in Node V12.* nickdesaulniers/node-nanomsg#206

Closed

daCapricorn mentioned this issue Jul 13, 2019

Electron 5+ Node 12 rebuild error theturtle32/WebSocket-Node#358

Closed

shdunning mentioned this issue Sep 20, 2019

Update deps for node12 support RedHatInsights/frontend-starter-app#77

Merged

pdufour pushed a commit to lob/pdffonts that referenced this issue Dec 6, 2019

Add support for node 12

5287062

See mapbox/node-cpp-skel#54 nodejs/nan#849

grapereader mentioned this issue Dec 25, 2019

broken on dbus nodejs 13 Shouqun/node-dbus#209

Closed

seyfer mentioned this issue Jan 22, 2020

Install failed after update to node 12, could nan require to v.14? nfroidure/ttf2woff2#57

Closed

IanBoyanZhang mentioned this issue Feb 8, 2020

Fail to bootstrap using node v12 cruise-automation/webviz#341

Open

ryanrd mentioned this issue Feb 19, 2020

fix: Procfile path, force node to node 10 sprucelabsai/workspace.sprucebot-skills-kit#814

Merged

3 tasks

tomocafe mentioned this issue Mar 1, 2020

Update theme e8y/reveal-teals#16

Closed

allanext mentioned this issue Jun 10, 2020

error: no matching function for call to ‘v8::String understrap/understrap-child#268

Closed

DeeDeeG mentioned this issue Jul 3, 2020

Use windows agent by default atom-community/atom#3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Node 12 #849

Support for Node 12 #849

xzyfer commented Apr 24, 2019

Flarna commented Apr 25, 2019 •

edited

matoro commented Apr 25, 2019

matoro commented Apr 25, 2019

Flarna commented Apr 25, 2019

matoro commented Apr 25, 2019

Flarna commented Apr 25, 2019

Flarna commented Apr 25, 2019

matoro commented Apr 25, 2019 •

edited

Flarna commented Apr 25, 2019

junderw commented Apr 26, 2019

xzyfer commented Apr 26, 2019 via email

lrecknagel commented Apr 26, 2019

Flarna commented Apr 26, 2019

darkgl0w commented May 10, 2019 •

edited

ccope commented May 10, 2019

Flarna commented May 10, 2019

bnoordhuis commented May 24, 2019

ralyodio commented Jun 6, 2019

kkoopa commented Jun 6, 2019

Support for Node 12 #849

Support for Node 12 #849

Comments

xzyfer commented Apr 24, 2019

Flarna commented Apr 25, 2019 • edited

matoro commented Apr 25, 2019

matoro commented Apr 25, 2019

Flarna commented Apr 25, 2019

matoro commented Apr 25, 2019

Flarna commented Apr 25, 2019

Flarna commented Apr 25, 2019

matoro commented Apr 25, 2019 • edited

Flarna commented Apr 25, 2019

junderw commented Apr 26, 2019

xzyfer commented Apr 26, 2019 via email

lrecknagel commented Apr 26, 2019

Flarna commented Apr 26, 2019

darkgl0w commented May 10, 2019 • edited

ccope commented May 10, 2019

Flarna commented May 10, 2019

bnoordhuis commented May 24, 2019

ralyodio commented Jun 6, 2019

kkoopa commented Jun 6, 2019

Flarna commented Apr 25, 2019 •

edited

matoro commented Apr 25, 2019 •

edited

darkgl0w commented May 10, 2019 •

edited