use GetBackingStore() instead GetContents() #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GetBackingStore() instead GetContents() for v8 >= 8.0 as GetContents() has been deprecated. Node.js 14 will use 8.1. It would be possible to use GetBackingStore() already with 7.9 but this would lead to issues with Node.js 13 as it uses 7.8 till 13.2.0. Additionally update testmatrix to use latest electron versions and add electron 8.
bnoordhuis
approved these changes
Mar 6, 2020
Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
GetBackingStore()insteadGetContents()for v8 >= 8.0 asGetContents()has been deprecated. Node.js 14 will use 8.1.It would be possible to use
GetBackingStore()already with 7.9 but this would lead to issues with Node.js 13 as it uses 7.8 till 13.2.0.Additionally update testmatrix to use latest electron versions and add electron 8.
Refs: nodejs/node#32108
Refs: nodejs/node#30339