Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly address #917 requires reimplementing
v8::ScriptOrigin
due to v8/v8@546939f (unintentionally?) breaking the oldScriptOrigin
constructor by makingresource_column_offset
required. Since the same commit markedScriptOrigin::ResourceLineOffset
andScriptOrigin::ResourceColumnOffset
as soon to be deprecated, they should be reimplemented. Finally, @bnoordhuis decided to add a requirement for passing av8::Isolate*
in v8/v8@ee3f5ba, with the other constructors facing future deprecation.