Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for next release? #907

Closed
1 task done
mhdawson opened this issue Feb 12, 2021 · 14 comments
Closed
1 task done

Time for next release? #907

mhdawson opened this issue Feb 12, 2021 · 14 comments

Comments

@mhdawson
Copy link
Member

It will have been 2 months from the last release next week. We should probably start thinking about doing a release.

So far I think we'd want to address the following before releasin:

@mhdawson
Copy link
Member Author

I'm thinking we should plan 2 releases. One fairly soon, and then one after April 30 to drop support for Node.js. This would make sure the last 3.x version is up to date.

@NickNaso what do you think of a release April 15th, and then a release May 6th with the only change being dropping support for 8.x?

@NickNaso
Copy link
Member

NickNaso commented Mar 31, 2021

Hi @mhdawson,
I agree with you about the next releases for node-addon-api. To recap we will have two new releases:

  • 3.2.0 that will be the last 3.x and we should deliver it within 15th April (We should define what we need to keep in this release).
  • 4.0.0 Removes support for Node.js 8 and deliver it within 6th May (We should define what we need to drop)

We can open two new issues to track the works on both releases.

@gabrielschulhof
Copy link
Contributor

From today's Node-API meeting:

The APIs in napi-inl.deprecated.h are good candidates for removal in 4.0.0, however, how shall we announce that we are removing them? Can we even remove them? Some folks might still be using them.

We should likely also resolve the issue of what to do when we attempt to throw an exception during environment shutdown before making a release.

Another problem we might want to solve before the next release is #906.

@mhdawson
Copy link
Member Author

mhdawson commented Apr 8, 2021

I'm thinking we should still leave "napi-inl.deprecated.h". I don't think they have been causing us any maintenance issues and I think we probably want to discuss more/message more if we are going to do it in advance.

In my mind the main or possibly only thing that we need in 4.0.0 is dropping support for Node.js 10.x once it is out of LTS.

@mhdawson
Copy link
Member Author

mhdawson commented May 3, 2021

@nodejs/node-api you can check out the discussion in #906 but the conclusion I have is that the intermittent failures we are seeing in the CI are not related to node-addon-api, but instead changes that are needed in core. Therefore we should be ok to move ahead with the releases we'd planned.

@NickNaso
Copy link
Member

I'm starting to work on release 3.2.0.

@NickNaso
Copy link
Member

NickNaso commented May 17, 2021

@NickNaso
Copy link
Member

The version 3.2.0 has been released. Enjoy.

@NickNaso NickNaso pinned this issue May 17, 2021
@NickNaso
Copy link
Member

I'm starting to prepare the release 3.2.1.

@NickNaso
Copy link
Member

NickNaso commented Jun 14, 2021

Hi everybody,
I want to work on release 4.0.0. From the last release 3.2.1 we have two noew commits:

May I proceed to create the new release removing the support for Node.js v10?
@nodejs/node-api

@NickNaso
Copy link
Member

NickNaso commented Jun 15, 2021

The release 4.0.0 has been published.

@NickNaso
Copy link
Member

I think that I can close the issue, if not feel free to reopen it.

@NickNaso NickNaso unpinned this issue Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants