Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

compile a proper diff of changes from node not in io.js #1

Closed
Fishrock123 opened this issue Apr 30, 2015 · 9 comments
Closed

compile a proper diff of changes from node not in io.js #1

Fishrock123 opened this issue Apr 30, 2015 · 9 comments
Labels

Comments

@Fishrock123
Copy link
Member

Something seems off about nodejs/node-v0.x-archive@3a9754a...master

I think 3a9754a was supposed to be io.js's base, however. cc @chrisdickinson?

But we have some of the changes into december, and I'm pretty sure they weren't ported ones.

@Fishrock123
Copy link
Member Author

hmmm, perhaps there is overlap because we merged in node back when it was node-forward/node?

@chrisdickinson
Copy link
Contributor

I did some work towards this here.

@chrisdickinson
Copy link
Contributor

The above was compiled from the commits since 372a2f5, which is the result of git merge-base node/master iojs/master in a repo where the origins are set up to point at the respective repos.

@jasnell
Copy link
Member

jasnell commented May 1, 2015

@chrisdickinson 👍 very nice and quite helpful.

@Fishrock123
Copy link
Member Author

So, might as well start going through.

comments in no particular order yet: (I'll re-arrange the commits by subsystem soon.)

V8 & libuv patches

Are those commits from node already on the deps as well? io.js has only accepted floating patches if they already exist upstream.

878c40e mdb_v8: fix symbols not loaded properly
ebfa7e3 mdb_v8: add tests for ::findjsobjects -k KIND
4312f8d mdb_v8: update for v0.12

We removed mdb_v8 entirely, as per nodejs/node#1023 .. what's it even do?

SSLv2/v3

As I think you already know, we removed that entirely as per nodejs/node#315

timers: Avoid linear scan in _unrefActive.

We should probably still port that over to io.js in some form soon anyways. There is however, a timers re-write in the pipe.

@piscisaureus
Copy link
Contributor

timers: Avoid linear scan in _unrefActive.

We should probably still port that over to io.js in some form soon anyways. There is however, a timers re-write in the pipe.

Although a marginal improvement, there is a much simpler solution to fix the problem this was intended to fix. That's why I didn't port it over from node 0.10 at the time.

@bnoordhuis
Copy link
Member

We removed mdb_v8 entirely, as per iojs#1023 .. what's it even do?

It's what Joyent uses for their dtrace and mdb jsstack integration. They don't bother to keep the V8 bits up to date and it's not relevant for non-SmartOS platforms so it got the ax.

@jasnell
Copy link
Member

jasnell commented Jun 3, 2015

@Fishrock123 ... do we need to keep this one open?

@Fishrock123
Copy link
Member Author

Hmmm, don't think so, we can always check back if we think we missed anything.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants