Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check that commits(first: 100 returns the most recent 100 commits, and not the oldest 100 #477

Closed
mmarchini opened this issue Aug 15, 2020 · 4 comments · Fixed by #520
Assignees
Labels

Comments

@mmarchini
Copy link
Contributor

As title says, our PRCommits.gql query uses first for commits. I'm not sure if it fetches the newest or oldest 100 commits. If whoever implemented this already tested it and remember the answer, that's enough for me too :)

@mmarchini mmarchini self-assigned this Aug 15, 2020
@targos
Copy link
Member

targos commented Aug 15, 2020

I just tested with https://developer.github.com/v4/explorer for that PR: nodejs/node#34752

With first: 5, it returns them from oldest to newest:
image

You can change to last: 5 to get the most recent commits (still ordered from old to new):

image

@codebytere
Copy link
Member

Meaning we should swap to last?

@mmarchini
Copy link
Contributor Author

Meaning we should swap to last?

That's what I understood, yes

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants