Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Updates #1562

Closed
joaocgreis opened this issue Oct 11, 2018 · 5 comments
Closed

CI Updates #1562

joaocgreis opened this issue Oct 11, 2018 · 5 comments

Comments

@joaocgreis
Copy link
Member

@nodejs/node-gyp FYI, let me know if there's an issue with any of this.

In nodegyp-test-pull-request:

  • Updated Node.js and npm versions.
  • Changed PR_ID to REMOTE_REF, this allows us to test anything invoking the multiple subjobs at once. The job name remains "test pull request", so the whole job tree could probably be reorganized to make more sense. For now, we can think of it as "not exclusively".
  • Skip Node.js v4 for node-gyp v4 (v0.10 and v0.12 were aready skipped).

In nodegyp-test-commit:

@joaocgreis
Copy link
Member Author

CI is currently broken for master, PR to fix: #1561

@joaocgreis
Copy link
Member Author

Added v11.0.0 to the matrix. Also added v6.0.0 because that's the oldest we support for v4, so should be tested.

@joaocgreis
Copy link
Member Author

Had to change to v6.2.1 because NVS was having issues with 6.0.0 - probably because the zip/7z packages are not available.

@refack
Copy link
Contributor

refack commented Oct 25, 2018

NVS was having issues with 6.0.0

But besides that it's a great tool for this task, right?

@joaocgreis
Copy link
Member Author

Haven't reviewed it carefully but it looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants