Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency CircularJSON with its successor flatted #1838

Closed
cclauss opened this issue Jul 23, 2019 · 2 comments
Closed

Replace dependency CircularJSON with its successor flatted #1838

cclauss opened this issue Jul 23, 2019 · 2 comments

Comments

@cclauss
Copy link
Contributor

cclauss commented Jul 23, 2019

Every time our Travis CI tests run, they generate the following warning:
$ npm install

npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

Would it be worthwhile to make this switch from the deprecated CircularJSON --> flatted?
Both are from WebReflection but they do NOT share the same LICENSE.

  • Node Version:
  • Platform:
  • Compiler:
  • Module:
Verbose output (from npm or node-gyp):
Paste your log here, between the backticks. It can be:
  - npm --verbose output,
  - or contents of npm-debug.log,
  - or output of node-gyp rebuild --verbose.
@bnoordhuis
Copy link
Member

That's not under our control. It's not a direct dependency, not even close:

$ npm ls circular-json
node-gyp@5.0.3 /Users/bnoordhuis/src/node-gyp
└─┬ standard@12.0.1
  └─┬ eslint@5.4.0
    └─┬ file-entry-cache@2.0.0
      └─┬ flat-cache@1.3.4
        └── circular-json@0.3.3 

@rvagg
Copy link
Member

rvagg commented Jul 26, 2019

needs an upgrade to standard@13

However there's a new rule for no spacing inside square brackets that makes my blood boil: standard/standard#1318

Let me get over my syntax rage and I'll put in a PR to "fix" this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants