windows build broken #183
Comments
|
Here's the file as generated on my side: class FixedArray::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return FixedArray::cast(raw_object).AllocatedSize();
}
};
class WeakFixedArray::BodyDescriptor final : public SuffixRangeWeakBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return WeakFixedArray::cast(raw_object).AllocatedSize();
}
};
class SloppyArgumentsElements::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return SloppyArgumentsElements::cast(raw_object).AllocatedSize();
}
};
class FeedbackVector::BodyDescriptor final : public SuffixRangeWeakBodyDescriptor<24> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return FeedbackVector::cast(raw_object).AllocatedSize();
}
};
class WeakArrayList::BodyDescriptor final : public SuffixRangeWeakBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return WeakArrayList::cast(raw_object).AllocatedSize();
}
};
class OnHeapBasicBlockProfilerData::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 56;
}
};
class ConsString::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 32;
}
};
class SeqOneByteString::BodyDescriptor final : public DataOnlyBodyDescriptor {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return SeqOneByteString::cast(raw_object).AllocatedSize();
}
};
class SeqTwoByteString::BodyDescriptor final : public DataOnlyBodyDescriptor {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return SeqTwoByteString::cast(raw_object).AllocatedSize();
}
};
class SlicedString::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 32;
}
};
class ThinString::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 24;
}
};
class InternalClass::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 24;
}
};
class SmiPair::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 24;
}
};
class SmiBox::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 24;
}
};
class ExportedSubClassBase::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 24;
}
};
class ExportedSubClass::BodyDescriptor final : public BodyDescriptorBase {
public:
static bool IsValidSlot(Map map, HeapObject obj, int offset) {
bool valid_slots[] = {1,1,1,0,1,};
return valid_slots[static_cast<unsigned int>(offset)/kTaggedSize];
}
template <typename ObjectVisitor>
static inline void IterateBody(Map map, HeapObject obj, int object_size, ObjectVisitor* v) {
IteratePointers(obj, 8, 24, v);
IteratePointer(obj, 32, v);
}
static inline int SizeOf(Map map, HeapObject raw_object) {
return 40;
}
};
class AbstractInternalClassSubclass1::BodyDescriptor final : public DataOnlyBodyDescriptor {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 8;
}
};
class AbstractInternalClassSubclass2::BodyDescriptor final : public DataOnlyBodyDescriptor {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 8;
}
};
class InternalClassWithSmiElements::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return InternalClassWithSmiElements::cast(raw_object).AllocatedSize();
}
};
class InternalClassWithStructElements::BodyDescriptor final : public SuffixRangeBodyDescriptor<16> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return InternalClassWithStructElements::cast(raw_object).AllocatedSize();
}
};
class ExportedSubClass2::BodyDescriptor final : public BodyDescriptorBase {
public:
static bool IsValidSlot(Map map, HeapObject obj, int offset) {
bool valid_slots[] = {1,1,1,0,1,};
return valid_slots[static_cast<unsigned int>(offset)/kTaggedSize];
}
template <typename ObjectVisitor>
static inline void IterateBody(Map map, HeapObject obj, int object_size, ObjectVisitor* v) {
IteratePointers(obj, 8, 24, v);
IteratePointer(obj, 32, v);
}
static inline int SizeOf(Map map, HeapObject raw_object) {
return 40;
}
};
class SortState::BodyDescriptor final : public SuffixRangeBodyDescriptor<8> {
public:
static inline int SizeOf(Map map, HeapObject raw_object) {
return 136;
}
}; |
|
Looks like need extra header include for msvc. |
|
What about the syntax errors? |
|
Not sure, but from my experience, fix front error will be helpfully for latter error. |
|
If you have an idea about which header should be included in which file(s), I'm happy to try it on my Windows machine. |
|
I have not got time to debug yet. I guess this not on hurry since v8 8.8 official release take some time ? |
|
Looks like something wrong with This file not generated on windows. |
|
It seems all other builds are also absent for the last 5 days. |
|
V8 now requires ICU 68. Canary should be fixed after nodejs/node#36187 lands. |
|
@tebbi I am not familiar with torque, any special part should I check for windows ? #183 (comment) |
|
@gengjiawen I checked with V8 8.8 PR (nodejs/node#36139) and the same files are present in the torque-generated directory on both Windows and Linux. |
|
Found it: it's the file Edit: other files are wrong. For example |
|
Okay, so the issue is in https://github.com/v8/v8/blob/7111248e40379c540ae4c0325a8fb7fc792b9d43/src/torque/source-positions.cc#L48-L55 The method is called with |
|
I'm trying a fix in GYP 🤞 |
|
I pushed the fix to nodejs/node@c220ba6 /cc @joyeecheung ? |
|
This module is not supposed to be requireable. I don't know yet why the condition at https://github.com/nodejs/node/blob/299984561eff45bddc5bb802e5b22d47277e5ca5/tools/code_cache/cache_builder.cc#L130 is true for it. |
|
Okay I found it. It's a side-effect of the gyp fix. |
|
I'm closing this. We can continue to track other Windows errors in nodejs/node#36139 |
https://github.com/nodejs/node-v8/runs/1340956947
The text was updated successfully, but these errors were encountered: