Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review state of canary in CI #234

Closed
targos opened this issue Jul 20, 2022 · 11 comments · Fixed by nodejs/node#45496
Closed

Review state of canary in CI #234

targos opened this issue Jul 20, 2022 · 11 comments · Fixed by nodejs/node#45496

Comments

@targos
Copy link
Member

targos commented Jul 20, 2022

Commit: d20ed02
CI: https://ci.nodejs.org/job/node-test-commit/55212/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4781/
@targos targos pinned this issue Jul 20, 2022
@targos
Copy link
Member Author

targos commented Jul 20, 2022 •
edited

This was referenced Jul 20, 2022
Closed
Merged
@targos
Copy link
Member Author

targos commented Aug 2, 2022

Some nightly release builds are red too: https://ci-release.nodejs.org/job/iojs+release/8644/

@targos
Copy link
Member Author

targos commented Sep 7, 2022

Commit: 882dcff
CI: https://ci.nodejs.org/job/node-test-commit/56245/

@targos
Copy link
Member Author

targos commented Sep 8, 2022

Commit: edbabba
CI: https://ci.nodejs.org/job/node-test-commit/56266/

@targos

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@targos
Copy link
Member Author

targos commented Sep 15, 2022

Commit: ef4184c
CI: https://ci.nodejs.org/job/node-test-commit/56400/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4857/

@targos
Copy link
Member Author

targos commented Sep 26, 2022

Commit: d3cfc11
CI: https://ci.nodejs.org/job/node-test-commit/56659/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4875/

@targos
Copy link
Member Author

targos commented Nov 16, 2022

Commit: ce32638
CI: https://ci.nodejs.org/job/node-test-commit/57946/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4990/

@targos
Copy link
Member Author

targos commented Nov 16, 2022

Build failure on AIX:

https://ci.nodejs.org/job/node-test-commit-aix/43725/nodes=aix72-ppc64/console

13:19:30   g++ -pthread -Wl,-bbigtoc -maix64 -Wl,-blibpath:/usr/lib:/lib:/opt/freeware/lib/pthread/ppc64 -maix64 -Wl,-bbigtoc  -o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/mksnapshot /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/embedded-empty.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/embedded-file-writer.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-aix.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-base.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-generic.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-mac.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/embedded/platform-embedded-file-writer-win.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/mksnapshot.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/mksnapshot/deps/v8/src/snapshot/snapshot-empty.o /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_init.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_libbase.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_libplatform.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/icu/libicui18n.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/icu/libicuucx.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/icu/libicudata.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_compiler.a /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers.a -ldl -lrt
13:19:40 ld: 0711-317 ERROR: Undefined symbol: TLS init function for v8::internal::g_current_isolate_
13:19:46 ld: 0711-317 ERROR: Undefined symbol: .TLS init function for v8::internal::g_current_isolate_
13:19:47 ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information.
13:19:47 collect2: error: ld returned 8 exit status
13:19:47 gmake[2]: *** [tools/v8_gypfiles/mksnapshot.target.mk:224: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/mksnapshot] Error 1

@nodejs/platform-aix

@V-for-Vasili
Copy link

V-for-Vasili commented Nov 16, 2022 •
edited

This is related to a linker issue with extern thread_local - patch to v8 main branch to fix this: https://chromium-review.googlesource.com/c/v8/v8/+/4031867/2

Edit: Better solution for this is to add -fno-extern-tls-init flag (used by v8 ninja build) to Node gyp build; Node main branch PR: nodejs/node#45496

@V-for-Vasili V-for-Vasili mentioned this issue Nov 17, 2022
Merged
@targos targos mentioned this issue Nov 20, 2022
Closed
@targos targos unpinned this issue Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aix: Fix V8 canary build V-for-Vasili/node
2 participants
@targos @V-for-Vasili