diff --git a/src/node_api.cc b/src/node_api.cc index 40e3f0ae4266e4..d7bc67bbcb5b11 100644 --- a/src/node_api.cc +++ b/src/node_api.cc @@ -10,7 +10,7 @@ #include #include - +#include // INT_MAX #include #include #include @@ -129,6 +129,9 @@ struct napi_env__ { do { \ static_assert(static_cast(NAPI_AUTO_LENGTH) == -1, \ "Casting NAPI_AUTO_LENGTH to int must result in -1"); \ + RETURN_STATUS_IF_FALSE((env), \ + (len == NAPI_AUTO_LENGTH) || len <= INT_MAX, \ + napi_invalid_arg); \ auto str_maybe = v8::String::NewFromUtf8( \ (env)->isolate, (str), v8::NewStringType::kInternalized, \ static_cast(len)); \ @@ -871,7 +874,7 @@ void napi_module_register(napi_module* mod) { // Warning: Keep in-sync with napi_status enum const char* error_messages[] = {nullptr, - "Invalid pointer passed as argument", + "Invalid argument", "An object was expected", "A string was expected", "A string or symbol was expected", diff --git a/test/addons-napi/test_string/test.js b/test/addons-napi/test_string/test.js index 6e4962d129a6a4..5ce3d739c7a941 100644 --- a/test/addons-napi/test_string/test.js +++ b/test/addons-napi/test_string/test.js @@ -69,3 +69,7 @@ assert.strictEqual(test_string.TestUtf8Insufficient(str6), str6.slice(0, 1)); assert.strictEqual(test_string.TestUtf16Insufficient(str6), str6.slice(0, 3)); assert.strictEqual(test_string.Utf16Length(str6), 5); assert.strictEqual(test_string.Utf8Length(str6), 14); + +assert.throws(() => { + test_string.TestLargeUtf8(); +}, /^Error: Invalid argument$/); diff --git a/test/addons-napi/test_string/test_string.c b/test/addons-napi/test_string/test_string.c index a588b6a1b4e290..01845e428054bc 100644 --- a/test/addons-napi/test_string/test_string.c +++ b/test/addons-napi/test_string/test_string.c @@ -1,3 +1,4 @@ +#include // INT_MAX #include #include "../common.h" @@ -201,6 +202,19 @@ napi_value Utf8Length(napi_env env, napi_callback_info info) { return output; } +napi_value TestLargeUtf8(napi_env env, napi_callback_info info) { + napi_value output; + if (SIZE_MAX > INT_MAX) { + NAPI_CALL(env, napi_create_string_utf8(env, "", ((size_t)INT_MAX) + 1, &output)); + } else { + // just throw the expected error as there is nothing to test + // in this case since we can't overflow + NAPI_CALL(env, napi_throw_error(env, NULL, "Invalid argument")); + } + + return output; +} + napi_value Init(napi_env env, napi_value exports) { napi_property_descriptor properties[] = { DECLARE_NAPI_PROPERTY("TestLatin1", TestLatin1), @@ -211,6 +225,7 @@ napi_value Init(napi_env env, napi_value exports) { DECLARE_NAPI_PROPERTY("TestUtf16Insufficient", TestUtf16Insufficient), DECLARE_NAPI_PROPERTY("Utf16Length", Utf16Length), DECLARE_NAPI_PROPERTY("Utf8Length", Utf8Length), + DECLARE_NAPI_PROPERTY("TestLargeUtf8", TestLargeUtf8), }; NAPI_CALL(env, napi_define_properties(