From 048e44087852d9683b9f690b0c003353cdc189d5 Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Mon, 29 Aug 2022 15:28:53 +0530 Subject: [PATCH] src: fix ssize_t error from nghttp2.h MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: https://github.com/electron/electron/pull/35350#discussion_r954890551 Signed-off-by: Darshan Sen PR-URL: https://github.com/nodejs/node/pull/44393 Reviewed-By: Matteo Collina Reviewed-By: Shelley Vohr Reviewed-By: Rafael Gonzaga Reviewed-By: Anna Henningsen Reviewed-By: Tobias Nießen Reviewed-By: James M Snell --- src/node_http2.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/node_http2.h b/src/node_http2.h index 5bd715da8a2697..fea51d2d7f3b28 100644 --- a/src/node_http2.h +++ b/src/node_http2.h @@ -3,8 +3,9 @@ #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS -// FIXME(joyeecheung): nghttp2.h needs stdint.h to compile on Windows -#include +// clang-format off +#include "node.h" // nghttp2.h needs ssize_t +// clang-format on #include "nghttp2/nghttp2.h" #include "env.h"