From 06b718363d27ab1e88288eab464cd1d8c6d79bde Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 23 Mar 2023 11:50:21 -0400 Subject: [PATCH] deps: V8: cherry-pick 3e4952cb2a59 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: [test] fix uninitialized error In op1a.Equals(&op3) call, that->parameter() is undefined. which triggers uninitialized error from gcc. Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714 Commit-Queue: Toon Verwaest Reviewed-by: Toon Verwaest Cr-Commit-Position: refs/heads/main@{#86267} Refs: https://github.com/v8/v8/commit/3e4952cb2a5969e42e782a66b948dc0ee88c812e PR-URL: https://github.com/nodejs/node/pull/47236 Reviewed-By: Jiawen Geng Reviewed-By: Michaël Zasso --- common.gypi | 2 +- deps/v8/test/cctest/compiler/test-operator.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index d1e24c52d81be0..407aaa577d14a4 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.15', + 'v8_embedder_string': '-node.16', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/test/cctest/compiler/test-operator.cc b/deps/v8/test/cctest/compiler/test-operator.cc index 7428359223b015..33f0d537f3bc81 100644 --- a/deps/v8/test/cctest/compiler/test-operator.cc +++ b/deps/v8/test/cctest/compiler/test-operator.cc @@ -210,7 +210,7 @@ TEST(TestOperator1double_Equals) { CHECK(!op2b.Equals(&op1a)); CHECK(!op2b.Equals(&op1b)); - Operator op3(25, NONE, "Weepy", 0, 0, 0, 0, 0, 0); + Operator1 op3(25, NONE, "Weepy", 0, 0, 0, 0, 0, 0, 1.1); CHECK(!op1a.Equals(&op3)); CHECK(!op1b.Equals(&op3));