From 0ac4a6ab16652fd7a935cebbf48f7a0beda093b3 Mon Sep 17 00:00:00 2001 From: Ben Turner <7623873+ben-turner@users.noreply.github.com> Date: Thu, 29 Oct 2020 12:56:34 -0700 Subject: [PATCH] doc: update crypto.createSecretKey history MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Passing strings to `crypto.createSecretKey` was not added until v15.0.0 (specifically with commit dae283d). The existing documentation implies its availability in prior versions which may cause confusion. PR-URL: https://github.com/nodejs/node/pull/35874 Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen --- doc/api/crypto.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/api/crypto.md b/doc/api/crypto.md index 95a5c68baf4bb2..e42051d4efca8e 100644 --- a/doc/api/crypto.md +++ b/doc/api/crypto.md @@ -2147,8 +2147,9 @@ added: v11.6.0 changes: - version: v15.0.0 pr-url: https://github.com/nodejs/node/pull/35093 - description: The key can also be an ArrayBuffer. The encoding argument was - added. The key cannot contain more than 2 ** 32 - 1 bytes. + description: The key can also be an ArrayBuffer or string. The encoding + argument was added. The key cannot contain more than + 2 ** 32 - 1 bytes. --> * `key` {string|ArrayBuffer|Buffer|TypedArray|DataView}