From 0ec2e1ddb5c607082412492b82dc1b8a7dbb27bc Mon Sep 17 00:00:00 2001 From: Yihong Wang Date: Tue, 24 Jul 2018 13:44:09 -0700 Subject: [PATCH] build: skip cctest on Windows shared lib build cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang --- node.gyp | 4 ++++ vcbuild.bat | 1 + 2 files changed, 5 insertions(+) diff --git a/node.gyp b/node.gyp index 75288114a8a4a1..fc47d733aa0a01 100644 --- a/node.gyp +++ b/node.gyp @@ -989,6 +989,10 @@ ['OS=="solaris"', { 'ldflags': [ '-I<(SHARED_INTERMEDIATE_DIR)' ] }], + # Skip cctest while building shared lib node for Windows + [ 'OS=="win" and node_shared=="true"', { + 'type': 'none', + }], ], } ], # end targets diff --git a/vcbuild.bat b/vcbuild.bat index 7c88c25ed1c259..bf41cbfb646c6c 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -542,6 +542,7 @@ if "%test_args%"=="" goto test-v8 if "%config%"=="Debug" set test_args=--mode=debug %test_args% if "%config%"=="Release" set test_args=--mode=release %test_args% if defined no_cctest echo Skipping cctest because no-cctest was specified && goto run-test-py +if not exist %config%\cctest.exe goto run-test-py echo running 'cctest %cctest_args%' "%config%\cctest" %cctest_args% :run-test-py