Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Revert "build: remove precompiled header and debug information for ho…
…st builds"

This reverts commit 818284b.

Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).

PR-URL: #45432
Refs: #42538
Refs: #42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
  • Loading branch information
StefanStojanovic authored and ruyadorno committed Nov 21, 2022
1 parent 8d96e2c commit 0f3cf7e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
6 changes: 1 addition & 5 deletions common.gypi
Expand Up @@ -283,11 +283,7 @@
'-std:c++17'
],
'BufferSecurityCheck': 'true',
'target_conditions': [
['_toolset=="target"', {
'DebugInformationFormat': 1 # /Z7 embed info in .obj files
}],
],
'DebugInformationFormat': 1, # /Z7 embed info in .obj files
'ExceptionHandling': 0, # /EHsc
'MultiProcessorCompilation': 'true',
'StringPooling': 'true', # pool string literals
Expand Down
12 changes: 5 additions & 7 deletions tools/v8_gypfiles/v8.gyp
Expand Up @@ -325,7 +325,7 @@
'<(V8_ROOT)/src/builtins/builtins-intl-gen.cc',
],
}],
['OS=="win" and _toolset=="target"', {
['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [
Expand Down Expand Up @@ -683,7 +683,7 @@
],
'sources': ['<@(v8_compiler_sources)'],
'conditions': [
['OS=="win" and _toolset=="target"', {
['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [
Expand All @@ -708,7 +708,7 @@
],
'sources': ['<@(v8_compiler_sources)'],
'conditions': [
['OS=="win" and _toolset=="target"', {
['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [
Expand Down Expand Up @@ -908,15 +908,13 @@
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")',
],
}],
['OS=="win" and _toolset=="target"', {
['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [
'<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)',
]
}],
['OS=="win"', {
],
# This will prevent V8's .cc files conflicting with the inspector's
# .cpp files in the same shard.
'msvs_settings': {
Expand Down

0 comments on commit 0f3cf7e

Please sign in to comment.