From 166df9e15cce98a10b8d681617b8caa7df927f9f Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 29 Apr 2018 20:37:19 -0700 Subject: [PATCH] doc: remove squash guideline from onboarding doc Although I agree with the guideline people should generally not squash commits in a pull request until the end (in other words, until it's time to land the PR), it is clear from comments and actions in the issue tracker that many do not share that view. This is fine by me, but I do think that we should our documentation should reflect our practices rather than being an aspirational statement. If we *do* wish to preserve this recommendation, it probably belongs in another document anyway as this is not a recommendation for Collaborators only but for anyone opening a pull request. PR-URL: https://github.com/nodejs/node/pull/20413 Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell --- doc/onboarding-extras.md | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index ffc316d7a670b6..62a7f7bb6b2837 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -97,4 +97,3 @@ to update from nodejs/node: ## Best practices * When making PRs, spend time writing a thorough description. -* Usually only squash at the end of your work.