From 17e10dd3cba06794830641cc0b65c87fd3f69109 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Fri, 6 Mar 2020 16:27:19 -0800 Subject: [PATCH] src: use C++ style for struct with initializers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes warning on clang 11: In file included from ../../src/node_http2.cc:6: ../../src/node_http2.h:508:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage] typedef struct { ^ SessionJSFields ../../src/node_http2.h:512:33: note: type is not C-compatible due to this default member initializer uint32_t max_invalid_frames = 1000; ^~~~ ../../src/node_http2.h:514:3: note: type is given name 'SessionJSFields' for linkage purposes by this typedef declaration } SessionJSFields; ^ PR-URL: https://github.com/nodejs/node/pull/32134 Reviewed-By: Anna Henningsen Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: David Carlier --- src/node_http2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_http2.h b/src/node_http2.h index 10a894eb653b20..c6b9938d2d8ef8 100644 --- a/src/node_http2.h +++ b/src/node_http2.h @@ -678,13 +678,13 @@ class Http2Stream::Provider::Stream : public Http2Stream::Provider { void* user_data); }; -typedef struct { +struct SessionJSFields { uint8_t bitfield; uint8_t priority_listener_count; uint8_t frame_error_listener_count; uint32_t max_invalid_frames = 1000; uint32_t max_rejected_streams = 100; -} SessionJSFields; +}; // Indices for js_fields_, which serves as a way to communicate data with JS // land fast. In particular, we store information about the number/presence