Skip to content

Commit 191d0ae

Browse files
mmarchiniaddaleax
authored andcommittedSep 22, 2020
build: add flag to build V8 with OBJECT_PRINT
Add a configure flag to build V8 with `-DOBJECT_PRINT`, which will expose auxiliar functions to inspect heap objects using native debuggers. Fixes: #32402 Signed-off-by: Mary Marchini <mmarchini@netflix.com> PR-URL: #32834 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 0ba9052 commit 191d0ae

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed
 

‎configure.py

+7
Original file line numberDiff line numberDiff line change
@@ -648,6 +648,12 @@
648648
'memory footprint, but also implies no just-in-time compilation ' +
649649
'support, thus much slower execution)')
650650

651+
parser.add_option('--v8-enable-object-print',
652+
action='store_true',
653+
dest='v8_enable_object_print',
654+
default=False,
655+
help='compile V8 with auxiliar functions for native debuggers')
656+
651657
parser.add_option('--node-builtin-modules-path',
652658
action='store',
653659
dest='node_builtin_modules_path',
@@ -1251,6 +1257,7 @@ def configure_v8(o):
12511257
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
12521258
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
12531259
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
1260+
o['variables']['v8_enable_object_print'] = 1 if options.v8_enable_object_print else 0
12541261
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
12551262
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
12561263
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1

0 commit comments

Comments
 (0)
Please sign in to comment.