From 19e712b9b2982404bbb4b8e1f9e1700ee8048d6f Mon Sep 17 00:00:00 2001 From: James M Snell Date: Fri, 7 Aug 2020 13:07:25 -0700 Subject: [PATCH] quic: resolve InitializeSecureContext TODO comment Using a static label is sufficient. PR-URL: https://github.com/nodejs/node/pull/34741 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott --- src/quic/node_quic_crypto.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/quic/node_quic_crypto.cc b/src/quic/node_quic_crypto.cc index 8f1f433525ecc3..b073ca9c381487 100644 --- a/src/quic/node_quic_crypto.cc +++ b/src/quic/node_quic_crypto.cc @@ -602,8 +602,6 @@ void InitializeSecureContext( BaseObjectPtr sc, bool early_data, ngtcp2_crypto_side side) { - // TODO(@jasnell): Using a static value for this at the moment but - // we need to determine if a non-static or per-session value is better. constexpr static unsigned char session_id_ctx[] = "node.js quic server"; switch (side) { case NGTCP2_CRYPTO_SIDE_SERVER: