From 19f67dba8a740130f10387e528a3942a33a848cf Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Thu, 1 Sep 2022 10:30:04 +0800 Subject: [PATCH] bootstrap: remove unused global parameter in per-context scripts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/44472 Reviewed-By: Chengzhong Wu Reviewed-By: Tobias Nießen Reviewed-By: Anna Henningsen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Minwoo Jung --- src/api/environment.cc | 2 +- src/node_builtins.cc | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/api/environment.cc b/src/api/environment.cc index e37fa8cb133704..01e25d3f92a49f 100644 --- a/src/api/environment.cc +++ b/src/api/environment.cc @@ -691,7 +691,7 @@ Maybe InitializePrimordials(Local context) { for (const char** module = context_files; *module != nullptr; module++) { // Arguments must match the parameters specified in // BuiltinLoader::LookupAndCompile(). - Local arguments[] = {context->Global(), exports, primordials}; + Local arguments[] = {exports, primordials}; MaybeLocal maybe_fn = builtins::BuiltinLoader::LookupAndCompile(context, *module, nullptr); Local fn; diff --git a/src/node_builtins.cc b/src/node_builtins.cc index 0ca360ddf1ef6f..4a8e5f2d23ecb5 100644 --- a/src/node_builtins.cc +++ b/src/node_builtins.cc @@ -349,7 +349,6 @@ MaybeLocal BuiltinLoader::LookupAndCompile( strlen("internal/per_context/")) == 0) { // internal/per_context/*: global, exports, primordials parameters = { - FIXED_ONE_BYTE_STRING(isolate, "global"), FIXED_ONE_BYTE_STRING(isolate, "exports"), FIXED_ONE_BYTE_STRING(isolate, "primordials"), };