From 1a293b066795222894807b225bfa2721fb759bff Mon Sep 17 00:00:00 2001 From: Yash Ladha Date: Tue, 30 Mar 2021 20:18:11 +0530 Subject: [PATCH] inspector: remove redundant method for connection check PR-URL: https://github.com/nodejs/node/pull/37986 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- src/inspector_agent.cc | 7 ------- src/inspector_agent.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index e74bf4d96da287..81dece656fc3bb 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -900,13 +900,6 @@ void Agent::ContextCreated(Local context, const ContextInfo& info) { client_->contextCreated(context, info); } -bool Agent::WillWaitForConnect() { - if (debug_options_.wait_for_connect()) return true; - if (parent_handle_) - return parent_handle_->WaitForConnect(); - return false; -} - bool Agent::IsActive() { if (client_ == nullptr) return false; diff --git a/src/inspector_agent.h b/src/inspector_agent.h index 08b8817f436286..1c8d496ba27a9e 100644 --- a/src/inspector_agent.h +++ b/src/inspector_agent.h @@ -59,8 +59,6 @@ class Agent { // --inspect command line flag) or if inspector JS API had been used. bool IsActive(); - // Option is set to wait for session connection - bool WillWaitForConnect(); // Blocks till frontend connects and sends "runIfWaitingForDebugger" void WaitForConnect(); // Blocks till all the sessions with "WaitForDisconnectOnShutdown" disconnect