Skip to content

Commit

Permalink
doc: simplify pull request template
Browse files Browse the repository at this point in the history
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

PR-URL: #36739
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
  • Loading branch information
Trott authored and targos committed May 1, 2021
1 parent 16a1650 commit 1a65b44
Showing 1 changed file with 8 additions and 14 deletions.
22 changes: 8 additions & 14 deletions .github/PULL_REQUEST_TEMPLATE.md
@@ -1,21 +1,15 @@
<!--
Thank you for your pull request. Please provide a description above and review
the requirements below.
Before submitting a pull request, please read
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md.
Bug fixes and new features should include tests and possibly benchmarks.
Commit message formatting guidelines:
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.
- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)

<!--
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
Expand Down

0 comments on commit 1a65b44

Please sign in to comment.