From 1a9138d67958d708506ae4f07f41c2e47d5bc672 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 26 Jun 2020 00:38:00 +0200 Subject: [PATCH] test: delete invalid test This test has not been working correctly since at least a555be2e45b2. Since it tests internals, any replacement test might become invalid in a similar way. Refs: https://github.com/nodejs/node/pull/34057 PR-URL: https://github.com/nodejs/node/pull/34445 Reviewed-By: James M Snell Reviewed-By: Rich Trott --- .../test-async-wrap-missing-method.js | 48 ------------------- 1 file changed, 48 deletions(-) delete mode 100644 test/parallel/test-async-wrap-missing-method.js diff --git a/test/parallel/test-async-wrap-missing-method.js b/test/parallel/test-async-wrap-missing-method.js deleted file mode 100644 index 038a77fba65964..00000000000000 --- a/test/parallel/test-async-wrap-missing-method.js +++ /dev/null @@ -1,48 +0,0 @@ -'use strict'; -const common = require('../common'); -const assert = require('assert'); - -const { MessageChannel } = require('worker_threads'); - -{ - const { port1, port2 } = new MessageChannel(); - - // Returning a non-function in the getter should not crash. - Object.defineProperty(port1, 'onmessage', { - get() { - port1.unref(); - return 42; - } - }); - - port2.postMessage({ foo: 'bar' }); - - // We need to start the port manually because .onmessage assignment tracking - // has been overridden. - port1.start(); - port1.ref(); -} - -{ - const err = new Error('eyecatcher'); - process.on('uncaughtException', common.mustCall((exception) => { - port1.unref(); - assert.strictEqual(exception, err); - })); - - const { port1, port2 } = new MessageChannel(); - - // Throwing in the getter should not crash. - Object.defineProperty(port1, 'onmessage', { - get() { - throw err; - } - }); - - port2.postMessage({ foo: 'bar' }); - - // We need to start the port manually because .onmessage assignment tracking - // has been overridden. - port1.start(); - port1.ref(); -}