Skip to content

Commit

Permalink
test: fix test-permission-deny-fs-wildcard (win32)
Browse files Browse the repository at this point in the history
The test fails on Windows when the working directory is not on a 'C:'
drive. For example, it always fails during the coverage-windows GitHub
action, which runs tests on drive 'D:'.

Fixes: #47093
PR-URL: #47095
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
  • Loading branch information
tniessen committed Mar 15, 2023
1 parent f543c05 commit 1cfe058
Showing 1 changed file with 18 additions and 15 deletions.
33 changes: 18 additions & 15 deletions test/parallel/test-permission-deny-fs-wildcard.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,28 @@ common.skipIfWorker();

const assert = require('assert');
const fs = require('fs');
const path = require('path');

if (common.isWindows) {
const { root } = path.parse(process.cwd());
const abs = (p) => path.join(root, p);
const denyList = [
'C:\\tmp\\*',
'C:\\example\\foo*',
'C:\\example\\bar*',
'C:\\folder\\*',
'C:\\show',
'C:\\slower',
'C:\\slown',
'C:\\home\\foo\\*',
];
'tmp\\*',
'example\\foo*',
'example\\bar*',
'folder\\*',
'show',
'slower',
'slown',
'home\\foo\\*',
].map(abs);
assert.ok(process.permission.deny('fs.read', denyList));
assert.ok(process.permission.has('fs.read', 'C:\\slow'));
assert.ok(process.permission.has('fs.read', 'C:\\slows'));
assert.ok(!process.permission.has('fs.read', 'C:\\slown'));
assert.ok(!process.permission.has('fs.read', 'C:\\home\\foo'));
assert.ok(!process.permission.has('fs.read', 'C:\\home\\foo\\'));
assert.ok(process.permission.has('fs.read', 'C:\\home\\fo'));
assert.ok(process.permission.has('fs.read', abs('slow')));
assert.ok(process.permission.has('fs.read', abs('slows')));
assert.ok(!process.permission.has('fs.read', abs('slown')));
assert.ok(!process.permission.has('fs.read', abs('home\\foo')));
assert.ok(!process.permission.has('fs.read', abs('home\\foo\\')));
assert.ok(process.permission.has('fs.read', abs('home\\fo')));
} else {
const denyList = [
'/tmp/*',
Expand Down

0 comments on commit 1cfe058

Please sign in to comment.