From 1d3405b05a0d61c07234d511b04edbaa73ee0f9b Mon Sep 17 00:00:00 2001 From: Denys Otrishko Date: Mon, 23 Dec 2019 16:38:55 +0200 Subject: [PATCH] test: log errors in test-http2-propagate-session-destroy-code PR-URL: https://github.com/nodejs/node/pull/31072 Reviewed-By: Luigi Pinca Reviewed-By: Anna Henningsen Reviewed-By: Gireesh Punathil Reviewed-By: Richard Lau Reviewed-By: Beth Griggs Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott --- .../parallel/test-http2-propagate-session-destroy-code.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-http2-propagate-session-destroy-code.js b/test/parallel/test-http2-propagate-session-destroy-code.js index a23bcfd07c32f9..f9e1d535720801 100644 --- a/test/parallel/test-http2-propagate-session-destroy-code.js +++ b/test/parallel/test-http2-propagate-session-destroy-code.js @@ -15,16 +15,16 @@ server.on('error', common.mustNotCall()); server.on('session', (session) => { session.on('close', common.mustCall()); session.on('error', common.mustCall((err) => { - assert(errRegEx.test(err)); + assert.ok(errRegEx.test(err), `server session err: ${err}`); assert.strictEqual(session.closed, false); assert.strictEqual(session.destroyed, true); })); session.on('stream', common.mustCall((stream) => { stream.on('error', common.mustCall((err) => { + assert.ok(errRegEx.test(err), `server stream err: ${err}`); assert.strictEqual(session.closed, false); assert.strictEqual(session.destroyed, true); - assert(errRegEx.test(err)); assert.strictEqual(stream.rstCode, destroyCode); })); @@ -36,7 +36,7 @@ server.listen(0, common.mustCall(() => { const session = http2.connect(`http://localhost:${server.address().port}`); session.on('error', common.mustCall((err) => { - assert(errRegEx.test(err)); + assert.ok(errRegEx.test(err), `client session err: ${err}`); assert.strictEqual(session.closed, false); assert.strictEqual(session.destroyed, true); })); @@ -44,7 +44,7 @@ server.listen(0, common.mustCall(() => { const stream = session.request({ [http2.constants.HTTP2_HEADER_PATH]: '/' }); stream.on('error', common.mustCall((err) => { - assert(errRegEx.test(err)); + assert.ok(errRegEx.test(err), `client stream err: ${err}`); assert.strictEqual(stream.rstCode, destroyCode); }));