Skip to content

Commit 1de1f67

Browse files
StefanStojanovicdanielleadams
authored andcommittedJan 3, 2023
Revert "build: remove precompiled header and debug information for host builds"
This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
1 parent d2998b6 commit 1de1f67

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed
 

‎common.gypi

+1-5
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,7 @@
283283
'-std:c++17'
284284
],
285285
'BufferSecurityCheck': 'true',
286-
'target_conditions': [
287-
['_toolset=="target"', {
288-
'DebugInformationFormat': 1 # /Z7 embed info in .obj files
289-
}],
290-
],
286+
'DebugInformationFormat': 1, # /Z7 embed info in .obj files
291287
'ExceptionHandling': 0, # /EHsc
292288
'MultiProcessorCompilation': 'true',
293289
'StringPooling': 'true', # pool string literals

‎tools/v8_gypfiles/v8.gyp

+5-7
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@
327327
'<(V8_ROOT)/src/builtins/builtins-intl-gen.cc',
328328
],
329329
}],
330-
['OS=="win" and _toolset=="target"', {
330+
['OS=="win"', {
331331
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
332332
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
333333
'sources': [
@@ -685,7 +685,7 @@
685685
],
686686
'sources': ['<@(v8_compiler_sources)'],
687687
'conditions': [
688-
['OS=="win" and _toolset=="target"', {
688+
['OS=="win"', {
689689
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
690690
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
691691
'sources': [
@@ -710,7 +710,7 @@
710710
],
711711
'sources': ['<@(v8_compiler_sources)'],
712712
'conditions': [
713-
['OS=="win" and _toolset=="target"', {
713+
['OS=="win"', {
714714
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
715715
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
716716
'sources': [
@@ -912,15 +912,13 @@
912912
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")',
913913
],
914914
}],
915-
['OS=="win" and _toolset=="target"', {
915+
['OS=="win"', {
916916
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
917917
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
918918
'sources': [
919919
'<(_msvs_precompiled_header)',
920920
'<(_msvs_precompiled_source)',
921-
]
922-
}],
923-
['OS=="win"', {
921+
],
924922
# This will prevent V8's .cc files conflicting with the inspector's
925923
# .cpp files in the same shard.
926924
'msvs_settings': {

0 commit comments

Comments
 (0)
Please sign in to comment.