From 1e6e5c3ef33112f8cec97ab700411b93adf26baf Mon Sep 17 00:00:00 2001 From: James M Snell Date: Thu, 6 Aug 2020 16:45:37 -0700 Subject: [PATCH] quic: resolve minor TODO in QuicSocket PR-URL: https://github.com/nodejs/node/pull/34655 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott --- src/quic/node_quic_socket.cc | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/quic/node_quic_socket.cc b/src/quic/node_quic_socket.cc index 0e054619df899a..cf7b128bb009c7 100644 --- a/src/quic/node_quic_socket.cc +++ b/src/quic/node_quic_socket.cc @@ -472,14 +472,7 @@ void QuicSocket::OnReceive( QuicCID dcid(pdcid, pdcidlen); QuicCID scid(pscid, pscidlen); - // TODO(@jasnell): It would be fantastic if Debug() could be - // modified to accept objects with a ToString-like capability - // similar to what we can do with TraceEvents... that would - // allow us to pass the QuicCID directly to Debug and have it - // converted to hex only if the category is enabled so we can - // skip committing resources here. - std::string dcid_hex = dcid.ToString(); - Debug(this, "Received a QUIC packet for dcid %s", dcid_hex.c_str()); + Debug(this, "Received a QUIC packet for dcid %s", dcid); BaseObjectPtr session = FindSession(dcid); @@ -489,7 +482,7 @@ void QuicSocket::OnReceive( // 3. The packet is a stateless reset sent by the peer // 4. This is a malicious or malformed packet. if (!session) { - Debug(this, "There is no existing session for dcid %s", dcid_hex.c_str()); + Debug(this, "There is no existing session for dcid %s", dcid); bool is_short_header = IsShortHeader(pversion, pscid, pscidlen); // Handle possible reception of a stateless reset token...