Skip to content

Commit

Permalink
build: fix commit-queue-rebase functionality
Browse files Browse the repository at this point in the history
For commit-queue-rebase only, commit-queue.sh uses `git push` which
requires the credentials from the git checkout. Remove
`persist-credentials: false` from this workflow.

PR-URL: #41140
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
Trott authored and danielleadams committed Dec 13, 2021
1 parent db26bdb commit 1fc6fd6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/commit-queue.yml
Expand Up @@ -26,7 +26,6 @@ jobs:
# Needs the whole git history for ncu to work
# See https://github.com/nodejs/node-core-utils/pull/486
fetch-depth: 0
persist-credentials: false
# A personal token is required because pushing with GITHUB_TOKEN will
# prevent commits from running CI after they land. It needs
# to be set here because `checkout` configures GitHub authentication
Expand Down

0 comments on commit 1fc6fd6

Please sign in to comment.