From 207df826df298cea03a2afb8021d3ef861275b74 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 8 Sep 2021 12:20:27 +0200 Subject: [PATCH] fixup! fs: add stream utilities to `FileHandle` --- .../test-fs-promises-file-handle-stream.js | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/test/parallel/test-fs-promises-file-handle-stream.js b/test/parallel/test-fs-promises-file-handle-stream.js index 4faea647486d9c..71f312b6f9d78c 100644 --- a/test/parallel/test-fs-promises-file-handle-stream.js +++ b/test/parallel/test-fs-promises-file-handle-stream.js @@ -11,7 +11,7 @@ const path = require('path'); const tmpdir = require('../common/tmpdir'); const assert = require('assert'); const { finished } = require('stream/promises'); -const { Blob } = require('buffer'); +const { buffer } = require('stream/consumers'); const tmpDir = tmpdir.path; tmpdir.refresh(); @@ -31,19 +31,15 @@ async function validateWrite() { async function validateRead() { const filePathForHandle = path.resolve(tmpDir, 'tmp-read.txt'); - const buffer = Buffer.from('Hello world'.repeat(100), 'utf8'); + const buf = Buffer.from('Hello world'.repeat(100), 'utf8'); - fs.writeFileSync(filePathForHandle, buffer); + fs.writeFileSync(filePathForHandle, buf); const fileHandle = await open(filePathForHandle); - - const chunks = []; - for await (const chunk of fileHandle.createReadStream()) { - chunks.push(chunk); - } - - const arrayBuffer = await new Blob(chunks).arrayBuffer(); - assert.deepStrictEqual(Buffer.from(arrayBuffer), buffer); + assert.deepStrictEqual( + await buffer(fileHandle.createReadStream()), + buf + ); } Promise.all([