From 21437f7a7f1df2d3958087d6f02def3ee7115b1e Mon Sep 17 00:00:00 2001 From: Ruy Adorno Date: Sat, 27 Aug 2022 05:54:40 -0400 Subject: [PATCH] doc: fix release guide example consistency This changeset fixes two consistency issues in this single example that guides releasers on how to push the tag to the remote repo. The first issue is that the remote git reference is consistently referred as `upstream` elsewhere in the guide. The second issue being that the version example used in the rest of the guide should be a fictional `v1.2.3` as stated in the "How to create a release" guide notes: > * Examples will use the fictional release version `1.2.3`. PR-URL: https://github.com/nodejs/node/pull/44385 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca --- doc/contributing/releases.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index eb03be2a07de0e..0c228d92f1c9e7 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -737,7 +737,7 @@ haven't pushed your tag first, then build promotion won't work properly. Push the tag using the following command: ```console -$ git push +$ git push upstream v1.2.3 ``` _Note_: Please do not push the tag unless you are ready to complete the