Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
quic: fixup session ticket app data todo comments
PR-URL: #34741
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
jasnell committed Aug 17, 2020
1 parent c17eaa3 commit 2405922
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions src/quic/node_quic_session.h
Expand Up @@ -616,20 +616,17 @@ class QuicApplication : public MemoryRetainer,

virtual void ResumeStream(int64_t stream_id) {}

virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) {
// TODO(@jasnell): Different QUIC applications may wish to set some
// application data in the session ticket (e.g. http/3 would set
// server settings in the application data). For now, doing nothing
// as I'm just adding the basic mechanism.
}

// Different QUIC applications may set some application data in
// the session ticket (e.g. http/3 would set server settings in the
// application data). By default, there's nothing to set.
virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) {}

// Different QUIC applications may set some application data in
// the session ticket (e.g. http/3 would set server settings in the
// application data). By default, there's nothing to get.
virtual SessionTicketAppData::Status GetSessionTicketAppData(
const SessionTicketAppData& app_data,
SessionTicketAppData::Flag flag) {
// TODO(@jasnell): Different QUIC application may wish to set some
// application data in the session ticket (e.g. http/3 would set
// server settings in the application data). For now, doing nothing
// as I'm just adding the basic mechanism.
return flag == SessionTicketAppData::Flag::STATUS_RENEW ?
SessionTicketAppData::Status::TICKET_USE_RENEW :
SessionTicketAppData::Status::TICKET_USE;
Expand Down

0 comments on commit 2405922

Please sign in to comment.