From 240592228bc794918443d46a8fcee85fe25a80d7 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Fri, 7 Aug 2020 13:05:46 -0700 Subject: [PATCH] quic: fixup session ticket app data todo comments PR-URL: https://github.com/nodejs/node/pull/34741 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott --- src/quic/node_quic_session.h | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/quic/node_quic_session.h b/src/quic/node_quic_session.h index c41d58125b9f70..7fd9d853bbcfbc 100644 --- a/src/quic/node_quic_session.h +++ b/src/quic/node_quic_session.h @@ -616,20 +616,17 @@ class QuicApplication : public MemoryRetainer, virtual void ResumeStream(int64_t stream_id) {} - virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) { - // TODO(@jasnell): Different QUIC applications may wish to set some - // application data in the session ticket (e.g. http/3 would set - // server settings in the application data). For now, doing nothing - // as I'm just adding the basic mechanism. - } - + // Different QUIC applications may set some application data in + // the session ticket (e.g. http/3 would set server settings in the + // application data). By default, there's nothing to set. + virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) {} + + // Different QUIC applications may set some application data in + // the session ticket (e.g. http/3 would set server settings in the + // application data). By default, there's nothing to get. virtual SessionTicketAppData::Status GetSessionTicketAppData( const SessionTicketAppData& app_data, SessionTicketAppData::Flag flag) { - // TODO(@jasnell): Different QUIC application may wish to set some - // application data in the session ticket (e.g. http/3 would set - // server settings in the application data). For now, doing nothing - // as I'm just adding the basic mechanism. return flag == SessionTicketAppData::Flag::STATUS_RENEW ? SessionTicketAppData::Status::TICKET_USE_RENEW : SessionTicketAppData::Status::TICKET_USE;