Skip to content

Commit 2488bc0

Browse files
addaleaxBethGriggs
authored andcommittedSep 21, 2021
doc: clean up weird notes about reentrancy
All N-API methods are reentrant, it does not make sense to talk about specific ones here. Some of these methods can run JS code, which of course can run other N-API code. For those methods, let’s note that down explicitly. PR-URL: #40107 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 8b80dcb commit 2488bc0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎doc/api/n-api.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -3303,7 +3303,6 @@ Returns `napi_ok` if the API succeeded.
33033303

33043304
This API implements the abstract operation `ToBoolean()` as defined in
33053305
[Section 7.1.2][] of the ECMAScript Language Specification.
3306-
This API can be re-entrant if getters are defined on the passed-in `Object`.
33073306

33083307
### napi_coerce_to_number
33093308
<!-- YAML
@@ -3325,7 +3324,8 @@ Returns `napi_ok` if the API succeeded.
33253324

33263325
This API implements the abstract operation `ToNumber()` as defined in
33273326
[Section 7.1.3][] of the ECMAScript Language Specification.
3328-
This API can be re-entrant if getters are defined on the passed-in `Object`.
3327+
This function potentially runs JS code if the passed-in value is an
3328+
object.
33293329

33303330
### napi_coerce_to_object
33313331
<!-- YAML
@@ -3347,7 +3347,6 @@ Returns `napi_ok` if the API succeeded.
33473347

33483348
This API implements the abstract operation `ToObject()` as defined in
33493349
[Section 7.1.13][] of the ECMAScript Language Specification.
3350-
This API can be re-entrant if getters are defined on the passed-in `Object`.
33513350

33523351
### napi_coerce_to_string
33533352
<!-- YAML
@@ -3369,7 +3368,8 @@ Returns `napi_ok` if the API succeeded.
33693368

33703369
This API implements the abstract operation `ToString()` as defined in
33713370
[Section 7.1.13][] of the ECMAScript Language Specification.
3372-
This API can be re-entrant if getters are defined on the passed-in `Object`.
3371+
This function potentially runs JS code if the passed-in value is an
3372+
object.
33733373

33743374
### napi_typeof
33753375
<!-- YAML

0 commit comments

Comments
 (0)
Please sign in to comment.