Skip to content

Commit

Permalink
build: add version info to timezone update PR
Browse files Browse the repository at this point in the history
Refs: #44950 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #45021
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
RaisinTen authored and danielleadams committed Jan 3, 2023
1 parent 7da66ef commit 2aac993
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/timezone-update.yml
Expand Up @@ -31,6 +31,9 @@ jobs:
persist-credentials: false
repository: unicode-org/icu-data

- name: Record new version
run: echo "new_version=$(ls icu-data/tzdata/icunew | tail -1)" >> $GITHUB_ENV

- run: ./tools/update-timezone.mjs

- name: Update the expected timezone version in test
Expand All @@ -52,7 +55,7 @@ jobs:
console.log(process.versions.tz)
```
branch: actions/timezone-update
commit-message: 'deps: update timezone'
commit-message: 'deps: update timezone to ${{ env.new_version }}'
labels: dependencies
title: 'deps: update timezone'
title: 'deps: update timezone to ${{ env.new_version }}'
reviewers: \@nodejs/i18n-api

0 comments on commit 2aac993

Please sign in to comment.